Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Make a QueryImage command from OTA Requestor to OTA Provider #10930

Closed
wants to merge 3 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Oct 25, 2021

A duplicate of #10875 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

carol-apple and others added 3 commits October 25, 2021 13:34
* Make ota-provider-app and ota-requestor-app compilable on Mac
* Remove self commissioning code from ota-requestor-app
* Add a parameter for IP address for OTA Requestor to use for creating secure session
* Add a parameter for fabric index for OTA Requestor to use for creating secure session
* Add a parameter for time to wait for OTA Requestor to initiate a QueryImage command from startup
- Avoid multiple calls to Server::GetInstance()
- Update parts of README
- Add TODO for workarounds to be removed later
- Remove usage of __FUNCTION__
@restyled-io restyled-io bot added the restyled label Oct 25, 2021
@todo
Copy link

todo bot commented Oct 25, 2021

This can be removed once OperationalDeviceProxy can resolve the IP Address from Node ID

// TODO: This can be removed once OperationalDeviceProxy can resolve the IP Address from Node ID
{ "ipaddress", chip::ArgParser::kArgumentRequired, kOptionIPAddress },
{ "delayQuery", chip::ArgParser::kArgumentRequired, kOptionDelayQuery },
{},
};
OptionSet cmdLineOptions = { HandleOptions, cmdLineOptionsDef, "PROGRAM OPTIONS",
" -n/--providerNodeId <node ID>\n"
" Node ID of the OTA Provider to connect to (hex format)\n\n"
" This assumes that you've already commissioned the OTA Provider node with chip-tool.\n"
" -f/--providerFabricIndex <fabric index>\n"


This comment was generated by todo based on a TODO comment in 037c27f in #10930. cc @project-chip.

@todo
Copy link

todo bot commented Oct 25, 2021

This is a workaround for OperationalDeviceProxy class to call OnNewConnection/OnConnectionExpired. Once

// TODO: This is a workaround for OperationalDeviceProxy class to call OnNewConnection/OnConnectionExpired. Once
// https://github.com/project-chip/connectedhomeip/issues/10423 is complete, this function can be removed.
void UpdateSession(bool connected);
/**
* In case there exists an open session to the device, mark it as expired.
*/


This comment was generated by todo based on a TODO comment in 037c27f in #10930. cc @project-chip.

@restyled-io restyled-io bot closed this Oct 25, 2021
@restyled-io restyled-io bot deleted the restyled/ota-requestor-connect branch October 25, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants