Restyle Make a QueryImage command from OTA Requestor to OTA Provider

examples/ota-provider-app/linux/README.md

@@ -10,12 +10,12 @@ Suggest doing the following:
 
 ## Usage
 
-`./ota-provider-app [--filepath \<filepath\>]`
+`./ota-provider-app [-f/--filepath \<file\>]`
 
-If `-filepath` is provided, `ota-provider-app` will automatically serve that
-file to the Requestor (SoftwareVersion will be Requester version + 1).
+If `--filepath` is supplied, `ota-provider-app` will automatically serve that
+file to the OTA Requestor (SoftwareVersion will be Requester version + 1).
 
-If no `-filepath` is provided, `ota-provider-app` will respond to `QueryImage`
+If no `--filepath` is supplied, `ota-provider-app` will respond to `QueryImage`
 with `NotAvailable` status.
 
 ## Current Features/Limitations
@@ -31,6 +31,5 @@ with `NotAvailable` status.
 -   Synchronous BDX transfer only
 -   using hardcoded test values for local and peer Node IDs
 -   does not check VID/PID
--   no configuration for `Busy`/`DelayedActionTime`
 -   no configuration for `AwaitNextAction`
 -   only one transfer at a time (does not check incoming `UpdateTokens`)

examples/ota-provider-app/ota-provider-common/BdxOtaSender.cpp

@@ -117,7 +117,7 @@ void BdxOtaSender::HandleTransferSessionOutput(TransferSession::OutputEvent & ev
         VerifyOrReturn(otaFile.good() || otaFile.eof(), ChipLogError(BDX, "%s: file read failed", __FUNCTION__));
 
         blockData.Data   = blockBuf->Start();
-        blockData.Length = otaFile.gcount();
+        blockData.Length = static_cast<size_t>(otaFile.gcount());
         blockData.IsEof  = (blockData.Length < blockSize) ||
             (mNumBytesSent + static_cast<uint64_t>(blockData.Length) == mTransfer.GetTransferLength() || (otaFile.peek() == EOF));
         mNumBytesSent = static_cast<uint32_t>(mNumBytesSent + blockData.Length);

examples/ota-requestor-app/linux/BUILD.gn

@@ -16,15 +16,12 @@ import("//build_overrides/build.gni")
 import("//build_overrides/chip.gni")
 
 executable("chip-ota-requestor-app") {
-  sources = [
-    "ExampleSelfCommissioning.h",
-    "PersistentStorage.cpp",
-    "main.cpp",
-  ]
+  sources = [ "main.cpp" ]
 
   deps = [
     "${chip_root}/examples/ota-requestor-app/ota-requestor-common",
     "${chip_root}/examples/platform/linux:app-main",
+    "${chip_root}/src/app/device",
     "${chip_root}/src/app/server",
     "${chip_root}/src/lib",
   ]