-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a QueryImage command from OTA Requestor to OTA Provider #10875
Make a QueryImage command from OTA Requestor to OTA Provider #10875
Conversation
This is a workaround for OperationalDeviceProxy class to call OnNewConnection/OnConnectionExpired. Onceconnectedhomeip/src/controller/CHIPDevice.h Lines 336 to 342 in f9182fb
This comment was generated by todo based on a
|
f9182fb
to
728fcf4
Compare
e7f12c0
to
44e3892
Compare
This can be removed once OperationalDeviceProxy can resolve the IP Address from Node IDconnectedhomeip/examples/ota-requestor-app/linux/main.cpp Lines 81 to 91 in 44e3892
This comment was generated by todo based on a
|
44e3892
to
17ca8d9
Compare
17ca8d9
to
5b896bd
Compare
5b896bd
to
4cfad70
Compare
PR #10875: Size comparison from d7151ac to 4cfad70 2 builds (for p6, telink)
Increases above 1.0% from d7151ac to 4cfad70:
18 builds (for efr32, k32w, linux, qpg)
4 builds (for mbed)
12 builds (for esp32, nrfconnect)
|
* Make ota-provider-app and ota-requestor-app compilable on Mac * Remove self commissioning code from ota-requestor-app * Add a parameter for IP address for OTA Requestor to use for creating secure session * Add a parameter for fabric index for OTA Requestor to use for creating secure session * Add a parameter for time to wait for OTA Requestor to initiate a QueryImage command from startup
4cfad70
to
9a38197
Compare
PR #10875: Size comparison from 5213452 to 9a38197 Increases above 1%:
Increases (4 builds for linux)
Decreases (1 build for linux)
Full report (24 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
- Avoid multiple calls to Server::GetInstance() - Update parts of README - Add TODO for workarounds to be removed later - Remove usage of __FUNCTION__
9a38197
to
951f8f9
Compare
PR #10875: Size comparison from 5213452 to 951f8f9 Increases above 1%:
Increases (4 builds for linux)
Decreases (1 build for linux)
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
…-chip#10875) * Make a QueryImage command from OTA Requestor to OTA Provider * Make ota-provider-app and ota-requestor-app compilable on Mac * Remove self commissioning code from ota-requestor-app * Add a parameter for IP address for OTA Requestor to use for creating secure session * Add a parameter for fabric index for OTA Requestor to use for creating secure session * Add a parameter for time to wait for OTA Requestor to initiate a QueryImage command from startup * Address code review comments - Avoid multiple calls to Server::GetInstance() - Update parts of README - Add TODO for workarounds to be removed later - Remove usage of __FUNCTION__
Problem
Currently, there is no code in ota-requestor-app to open a secure session to ota-provider-app in order to send QueryImage command and begin the OTA process.
Fixes: #9523
Change overview
Provided extra parameters to the ota-requestor-app to support secure session establishment and a way to trigger the QueryImage command.
After a specified amount of time (supplied by user on the command line when launching ota-requestor-app), use the
OperatioanlDeviceProxy
class to create a secure session between ota-requestor-app and ota-provider-app. Once the secure session has been established, send theQueryImage
command to the ota-provider-app.Testing
Tested manually using the ota-requestor-app and ota-provider-app:
chip-ota-provider-app -f test.bin
-f test.bin
is a dummy file that resides locally to ota-provider-app locationchip-tool pairing onnetwork 0xBEEFFEEB 20202021
chip-ota-requestor-app -d 30 -u 5550 -i 192.168.4.55 -n 0x00000000BEEFFEEB -q 10
-d 30
is the discriminator to help with commissioning-u 5550
is the UDP port to help with commissioning-i 192.168.4.55
is the IP address of the ota-provider-app that has been resolved manually-n 0x00000000BEEFFEEB
is the node ID of the ota-provider-app-q 10
is the amount of time in seconds to wait before initiating secure session estabishmentchip-tool pairing onnetwork-long 0x1234567890 20202021 30
test.bin
file is downloaded by the ota-requestor-app