Fix some places where we use OCTET_STRING when we should use CHAR_STRING #10745

bzbarsky-apple · 2021-10-21T00:54:39Z

Problem

Various XML uses OCTET_STRING for historical reasons when it should use CHAR_STRING.

Change overview

Fix XML to use CHAR_STRING as needed, fix up a few zapt files to correctly log CHAR_STRING, fix resulting compile errors.

Fixes #5542
Fixes #6112
Fixes #7322
Fixes #7654
Fixes #7655
Fixes #8704
Fixes #8705
Fixes #8706
Fixes #8707
Fixes #9797
Fixes #9798
Fixes #10508
Fixes #10509

Testing

Compiled the tree.

todo · 2021-10-21T00:54:41Z

This size is obviously wrong. See

connectedhomeip/examples/bridge-app/linux/main.cpp

Lines 203 to 213 in 4f35db6

    
           // TODO: This size is obviously wrong.  See 
        
           // https://github.com/project-chip/connectedhomeip/issues/10743 
        
           labelStruct.label = CharSpan(label, kFixedLabelElementsOctetStringSize); 
        
           strncpy(zclOctetStrBuf, value, sizeof(zclOctetStrBuf)); 
        
           // TODO: This size is obviously wrong.  See 
        
           // https://github.com/project-chip/connectedhomeip/issues/10743 
        
           labelStruct.value = CharSpan(&zclOctetStrBuf[0], sizeof(zclOctetStrBuf)); 
        
           emberAfCopyList(ZCL_FIXED_LABEL_CLUSTER_ID, am, true, buffer, reinterpret_cast<uint8_t *>(&labelStruct), 1); 
        
           emberAfCopyList(ZCL_FIXED_LABEL_CLUSTER_ID, am, true, buffer, reinterpret_cast<uint8_t *>(&listCount), 0);

This comment was generated by todo based on a `TODO` comment in `4f35db6` in #10745. cc @bzbarsky-apple.

todo · 2021-10-21T00:54:44Z

This size is obviously wrong. See

connectedhomeip/examples/bridge-app/linux/main.cpp

Lines 208 to 213 in 4f35db6

    
           // TODO: This size is obviously wrong.  See 
        
           // https://github.com/project-chip/connectedhomeip/issues/10743 
        
           labelStruct.value = CharSpan(&zclOctetStrBuf[0], sizeof(zclOctetStrBuf)); 
        
           emberAfCopyList(ZCL_FIXED_LABEL_CLUSTER_ID, am, true, buffer, reinterpret_cast<uint8_t *>(&labelStruct), 1); 
        
           emberAfCopyList(ZCL_FIXED_LABEL_CLUSTER_ID, am, true, buffer, reinterpret_cast<uint8_t *>(&listCount), 0);

This comment was generated by todo based on a `TODO` comment in `4f35db6` in #10745. cc @bzbarsky-apple.

github-actions · 2021-10-21T01:23:45Z

Size increase report for "gn_qpg-example-build" from 6e22d13

File	Section	File	VM
chip-qpg6100-lighting-example.out	.text	-64	-64

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,1074
.debug_line,0,291
.debug_loc,0,266
.debug_abbrev,0,77
[Unmapped],0,64
.debug_str,0,32
.shstrtab,0,-1
.strtab,0,-11
.debug_ranges,0,-48
.text,-64,-64

github-actions · 2021-10-21T01:27:57Z

PR #10745: Size comparison from 6e22d13 to 4f35db6

20 builds (for efr32, k32w, linux, p6, qpg, telink)

platform	target	config	section	`6e22d13`	`4f35db6`	change	% change
efr32	lighting-app	BRD4161A	.bss	118028	118028	0	0.0
			.data	1800	1800	0	0.0
			.text	782888	782776	-112	-0.0
	lock-app	BRD4161A	.bss	115884	115884	0	0.0
			.data	1760	1760	0	0.0
			.text	762024	761928	-96	-0.0
	window-app	BRD4161A	.bss	116204	116204	0	0.0
			.data	1764	1764	0	0.0
			.text	762940	762828	-112	-0.0
	lighting-app	BRD4161A+rpc	.bss	131356	131356	0	0.0
			.data	1852	1852	0	0.0
			.text	762604	762508	-96	-0.0
k32w	lock-app	k32w061+debug	.bss	69060	69060	0	0.0
			.data	1864	1864	0	0.0
			.text	515556	515492	-64	-0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	357336	357336	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78584	78584	0	0.0
			.data	1900	1900	0	0.0
			.text	614324	614260	-64	-0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	59072	59072	0	0.0
			.dynamic	592	592	0	0.0
			.got	4080	4080	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136245	136245	0	0.0
			.text	1341586	1342338	752	0.1
	chip-tool	debug	.bss	17520	17520	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	91920	91920	0	0.0
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	184004	184004	0	0.0
			.text	3456805	3457109	304	0.0
	ota-provider-app	debug	.bss	37440	37440	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110024	110024	0	0.0
			.text	1009586	1010018	432	0.0
	ota-requestor-app	debug	.bss	205696	205696	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128776	128776	0	0.0
			.text	`1129490`	1129666	176	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71823	71823	0	0.0
			.text	569906	569906	0	0.0
	tv-app	debug	.bss	216560	216560	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	56096	56096	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	153384	153384	0	0.0
			.text	1444114	1444562	448	0.0
	bridge-app	debug+rpc	.bss	52880	52880	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110620	110620	0	0.0
			.text	`1050661`	1051173	512	0.0
	lighting-app	debug+rpc	.bss	42200	42200	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127793	127793	0	0.0
			.text	1250898	1251362	464	0.0
p6	lock-app	default	.bss	68208	68208	0	0.0
			.data	2416	2416	0	0.0
			.heap	962720	962720	0	0.0
			.text	1126536	1126472	-64	-0.0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0	0.0
			.data	996	996	0	0.0
			.text	486644	486580	-64	-0.0
	lock-app	qpg6100+debug	.bss	52496	52496	0	0.0
			.data	952	952	0	0.0
			.text	462712	462648	-64	-0.0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0	0.0
			.data	280	280	0	0.0
			.text	102708	102708	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	70992	70992	0	0.0
			noinit	33216	33216	0	0.0
			text	458348	458264	-84	-0.0

2 builds (for mbed)

platform	target	config	section	`6e22d13`	`4f35db6`	change	% change
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172092	172092	0	0.0
			.data	5464	5464	0	0.0
			.heap	858888	858888	0	0.0
			.text	1220152	1220152	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171012	171012	0	0.0
			.data	5432	5432	0	0.0
			.heap	860000	860000	0	0.0
			.text	1198048	1197984	-64	-0.0

10 builds (for nrfconnect)

platform	target	config	section	`6e22d13`	`4f35db6`	change	% change
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112476	112476	0	0.0
			rodata	97780	97780	0	0.0
			text	577800	577724	-76	-0.0
	lock-app	nrf52840dk_nrf52840	bss	111544	111544	0	0.0
			rodata	94116	94116	0	0.0
			text	559288	559212	-76	-0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339456	339456	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	111612	111612	0	0.0
			rodata	95096	95096	0	0.0
			text	562440	562364	-76	-0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	111552	111552	0	0.0
			rodata	94176	94176	0	0.0
			text	559080	559004	-76	-0.0
	shell	nrf52840dk_nrf52840	bss	107316	107316	0	0.0
			rodata	71644	71644	0	0.0
			text	519032	519032	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108720	108720	0	0.0
			rodata	88564	88564	0	0.0
			text	551000	550924	-76	-0.0
		nrf5340dk_nrf5340_cpuapp	bss	113852	113852	0	0.0
			rodata	93020	93020	0	0.0
			text	507264	507188	-76	-0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112916	112916	0	0.0
			rodata	89376	89376	0	0.0
			text	488744	488668	-76	-0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0	0.0
			rodata	66288	66288	0	0.0
			text	439632	439632	0	0.0

github-actions · 2021-10-21T03:48:20Z

PR #10745: Size comparison from 6e22d13 to 847294c

12 builds (for efr32, k32w, p6, qpg, telink)

platform	target	config	section	`6e22d13`	`847294c`	change	% change
efr32	lighting-app	BRD4161A	.bss	118028	118028	0	0.0
			.data	1800	1800	0	0.0
			.text	782888	782776	-112	-0.0
	lock-app	BRD4161A	.bss	115884	115884	0	0.0
			.data	1760	1760	0	0.0
			.text	762024	761928	-96	-0.0
	window-app	BRD4161A	.bss	116204	116204	0	0.0
			.data	1764	1764	0	0.0
			.text	762940	762828	-112	-0.0
	lighting-app	BRD4161A+rpc	.bss	131356	131356	0	0.0
			.data	1852	1852	0	0.0
			.text	762604	762508	-96	-0.0
k32w	lock-app	k32w061+debug	.bss	69060	69060	0	0.0
			.data	1864	1864	0	0.0
			.text	515556	515492	-64	-0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	357336	357336	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78584	78584	0	0.0
			.data	1900	1900	0	0.0
			.text	614324	614260	-64	-0.0
p6	lock-app	default	.bss	68208	68208	0	0.0
			.data	2416	2416	0	0.0
			.heap	962720	962720	0	0.0
			.text	1126536	1126472	-64	-0.0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0	0.0
			.data	996	996	0	0.0
			.text	486644	486580	-64	-0.0
	lock-app	qpg6100+debug	.bss	52496	52496	0	0.0
			.data	952	952	0	0.0
			.text	462712	462648	-64	-0.0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0	0.0
			.data	280	280	0	0.0
			.text	102708	102708	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	70992	70992	0	0.0
			noinit	33216	33216	0	0.0
			text	458348	458264	-84	-0.0

10 builds (for linux, mbed)

platform	target	config	section	`6e22d13`	`847294c`	change	% change
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	59072	59072	0	0.0
			.dynamic	592	592	0	0.0
			.got	4080	4080	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136245	136245	0	0.0
			.text	1341586	`1342274`	688	0.1
	chip-tool	debug	.bss	17520	17520	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	91920	91920	0	0.0
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	184004	184004	0	0.0
			.text	3456805	3457109	304	0.0
	ota-provider-app	debug	.bss	37440	37440	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110024	110024	0	0.0
			.text	1009586	1009954	368	0.0
	ota-requestor-app	debug	.bss	205696	205696	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128776	128776	0	0.0
			.text	`1129490`	1129666	176	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71823	71823	0	0.0
			.text	569906	569906	0	0.0
	tv-app	debug	.bss	216560	216560	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	56096	56096	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	153384	153384	0	0.0
			.text	1444114	1444498	384	0.0
	bridge-app	debug+rpc	.bss	52880	52880	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110620	110620	0	0.0
			.text	`1050661`	1051173	512	0.0
	lighting-app	debug+rpc	.bss	42200	42200	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127793	127793	0	0.0
			.text	1250898	1251362	464	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172092	172092	0	0.0
			.data	5464	5464	0	0.0
			.heap	858888	858888	0	0.0
			.text	1220152	1220152	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171012	171012	0	0.0
			.data	5432	5432	0	0.0
			.heap	860000	860000	0	0.0
			.text	1198048	1197984	-64	-0.0

Fixes project-chip#5542 Fixes project-chip#6112 Fixes project-chip#7112 Fixes project-chip#7322 Fixes project-chip#7654 Fixes project-chip#7655 Fixes project-chip#8704 Fixes project-chip#8705 Fixes project-chip#8706 Fixes project-chip#8707 Fixes project-chip#9797 Fixes project-chip#9798 Fixes project-chip#10508 Fixes project-chip#10509

github-actions · 2021-10-21T04:28:39Z

PR #10745: Size comparison from 6e22d13 to 71e75e9

8 builds (for k32w, p6, qpg, telink)

platform	target	config	section	`6e22d13`	`71e75e9`	change	% change
k32w	lock-app	k32w061+debug	.bss	69060	69060	0	0.0
			.data	1864	1864	0	0.0
			.text	515556	515492	-64	-0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	357336	357336	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78584	78584	0	0.0
			.data	1900	1900	0	0.0
			.text	614324	614260	-64	-0.0
p6	lock-app	default	.bss	68208	68208	0	0.0
			.data	2416	2416	0	0.0
			.heap	962720	962720	0	0.0
			.text	1126536	1126472	-64	-0.0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0	0.0
			.data	996	996	0	0.0
			.text	486644	486580	-64	-0.0
	lock-app	qpg6100+debug	.bss	52496	52496	0	0.0
			.data	952	952	0	0.0
			.text	462712	462648	-64	-0.0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0	0.0
			.data	280	280	0	0.0
			.text	102708	102708	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	70992	70992	0	0.0
			noinit	33216	33216	0	0.0
			text	458348	458264	-84	-0.0

14 builds (for efr32, linux, mbed)

platform	target	config	section	`6e22d13`	`71e75e9`	change	% change
efr32	lighting-app	BRD4161A	.bss	118028	118028	0	0.0
			.data	1800	1800	0	0.0
			.text	782888	782776	-112	-0.0
	lock-app	BRD4161A	.bss	115884	115884	0	0.0
			.data	1760	1760	0	0.0
			.text	762024	761928	-96	-0.0
	window-app	BRD4161A	.bss	116204	116204	0	0.0
			.data	1764	1764	0	0.0
			.text	762940	762828	-112	-0.0
	lighting-app	BRD4161A+rpc	.bss	131356	131356	0	0.0
			.data	1852	1852	0	0.0
			.text	762604	762508	-96	-0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	59072	59072	0	0.0
			.dynamic	592	592	0	0.0
			.got	4080	4080	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136245	136245	0	0.0
			.text	1341586	`1342274`	688	0.1
	chip-tool	debug	.bss	17520	17520	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	91920	91920	0	0.0
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	184004	184004	0	0.0
			.text	3456805	3457109	304	0.0
	ota-provider-app	debug	.bss	37440	37440	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110024	110024	0	0.0
			.text	1009586	1009954	368	0.0
	ota-requestor-app	debug	.bss	205696	205696	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128776	128776	0	0.0
			.text	`1129490`	1129666	176	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71823	71823	0	0.0
			.text	569906	569906	0	0.0
	tv-app	debug	.bss	216560	216560	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	56096	56096	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	153384	153384	0	0.0
			.text	1444114	1444498	384	0.0
	bridge-app	debug+rpc	.bss	52880	52880	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110620	110620	0	0.0
			.text	`1050661`	1051173	512	0.0
	lighting-app	debug+rpc	.bss	42200	42200	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127793	127793	0	0.0
			.text	1250898	1251362	464	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172092	172092	0	0.0
			.data	5464	5464	0	0.0
			.heap	858888	858888	0	0.0
			.text	1220152	1220152	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171012	171012	0	0.0
			.data	5432	5432	0	0.0
			.heap	860000	860000	0	0.0
			.text	1198048	1197984	-64	-0.0

12 builds (for esp32, nrfconnect)

platform	target	config	section	`6e22d13`	`71e75e9`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60320	60320	0	0.0
			.dram0.data	16200	16200	0	0.0
			.flash.rodata	199128	199128	0	0.0
			.flash.text	872714	872718	4	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62824	62824	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207872	207872	0	0.0
			.flash.text	903835	903931	96	0.0
			.iram0.text	125115	125115	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112476	112476	0	0.0
			rodata	97780	97780	0	0.0
			text	577800	577724	-76	-0.0
	lock-app	nrf52840dk_nrf52840	bss	111544	111544	0	0.0
			rodata	94116	94116	0	0.0
			text	559288	559212	-76	-0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339456	339456	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	111612	111612	0	0.0
			rodata	95096	95096	0	0.0
			text	562440	562364	-76	-0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	111552	111552	0	0.0
			rodata	94176	94176	0	0.0
			text	559080	559004	-76	-0.0
	shell	nrf52840dk_nrf52840	bss	107316	107316	0	0.0
			rodata	71644	71644	0	0.0
			text	519032	519032	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108720	108720	0	0.0
			rodata	88564	88564	0	0.0
			text	551000	550924	-76	-0.0
		nrf5340dk_nrf5340_cpuapp	bss	113852	113852	0	0.0
			rodata	93020	93020	0	0.0
			text	507264	507188	-76	-0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112916	112916	0	0.0
			rodata	89376	89376	0	0.0
			text	488744	488668	-76	-0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0	0.0
			rodata	66288	66288	0	0.0
			text	439632	439632	0	0.0

github-actions · 2021-10-21T05:22:06Z

Size increase report for "nrfconnect-example-build" from 6e22d13

File	Section	File	VM
chip-lock.elf	device_handles	-4	-4
chip-lock.elf	text	-76	-76

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,1044
.debug_loc,0,391
.debug_line,0,279
.debug_abbrev,0,77
.debug_str,0,33
device_handles,-4,-4
.debug_ranges,0,-32
text,-76,-76

github-actions · 2021-10-21T05:36:52Z

Size increase report for "esp32-example-build" from 6e22d13

File	Section	File	VM
chip-all-clusters-app.elf	.flash.text	4	4

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,1730
.debug_loc,0,1220
.debug_line,0,1098
.debug_ranges,0,168
.debug_str,0,142
.strtab,0,48
.debug_abbrev,0,42
.symtab,0,16
.flash.text,4,4
[Unmapped],0,-4

boring-cyborg bot added app controller darwin examples labels Oct 21, 2021

pullapprove bot requested review from vivien-apple, wbschiller, woody-apple, yufengwangca and yunhanw-google October 21, 2021 00:55

pullapprove bot added the review - pending label Oct 21, 2021

saurabhst approved these changes Oct 21, 2021

View reviewed changes

bzbarsky-apple force-pushed the fix-char-string-loose-ends branch from 4f35db6 to 847294c Compare October 21, 2021 03:18

bzbarsky-apple added 2 commits October 21, 2021 00:07

Regenerate generated files

71e75e9

bzbarsky-apple force-pushed the fix-char-string-loose-ends branch from 847294c to 71e75e9 Compare October 21, 2021 04:07

emargolis approved these changes Oct 21, 2021

View reviewed changes

jmartinez-silabs approved these changes Oct 21, 2021

View reviewed changes

woody-apple approved these changes Oct 21, 2021

View reviewed changes

woody-apple merged commit b7f98f7 into project-chip:master Oct 21, 2021

todo bot mentioned this pull request Oct 21, 2021

This size is obviously wrong. See #10781

Closed

bzbarsky-apple mentioned this pull request Oct 21, 2021

Add Mode Select Cluster #10752

Merged

pullapprove bot added review - approved and removed review - pending labels Oct 21, 2021

bzbarsky-apple deleted the fix-char-string-loose-ends branch October 21, 2021 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some places where we use OCTET_STRING when we should use CHAR_STRING #10745

Fix some places where we use OCTET_STRING when we should use CHAR_STRING #10745

bzbarsky-apple commented Oct 21, 2021 •

edited

Loading

todo bot commented Oct 21, 2021

todo bot commented Oct 21, 2021

github-actions bot commented Oct 21, 2021

github-actions bot commented Oct 21, 2021 •

edited

Loading

github-actions bot commented Oct 21, 2021 •

edited

Loading

github-actions bot commented Oct 21, 2021 •

edited

Loading

github-actions bot commented Oct 21, 2021

github-actions bot commented Oct 21, 2021

Fix some places where we use OCTET_STRING when we should use CHAR_STRING #10745

Fix some places where we use OCTET_STRING when we should use CHAR_STRING #10745

Conversation

bzbarsky-apple commented Oct 21, 2021 • edited Loading

Problem

Change overview

Testing

todo bot commented Oct 21, 2021

This size is obviously wrong. See

This comment was generated by todo based on a TODO comment in 4f35db6 in #10745. cc @bzbarsky-apple.

todo bot commented Oct 21, 2021

This size is obviously wrong. See

This comment was generated by todo based on a TODO comment in 4f35db6 in #10745. cc @bzbarsky-apple.

github-actions bot commented Oct 21, 2021

github-actions bot commented Oct 21, 2021 • edited Loading

github-actions bot commented Oct 21, 2021 • edited Loading

github-actions bot commented Oct 21, 2021 • edited Loading

github-actions bot commented Oct 21, 2021

github-actions bot commented Oct 21, 2021

bzbarsky-apple commented Oct 21, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `4f35db6` in #10745. cc @bzbarsky-apple.

This comment was generated by todo based on a `TODO` comment in `4f35db6` in #10745. cc @bzbarsky-apple.

github-actions bot commented Oct 21, 2021 •

edited

Loading

github-actions bot commented Oct 21, 2021 •

edited

Loading

github-actions bot commented Oct 21, 2021 •

edited

Loading