Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The type of 'label' should be 'CharSpan', need to fix the XML definition for bro... #10508

Closed
todo bot opened this issue Oct 14, 2021 · 0 comments · Fixed by #10745
Closed

The type of 'label' should be 'CharSpan', need to fix the XML definition for bro... #10508

todo bot opened this issue Oct 14, 2021 · 0 comments · Fixed by #10745
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Oct 14, 2021

// TODO: The type of 'label' should be 'CharSpan', need to fix the XML definition for broken member type.
fabricDescriptor.label =
ByteSpan(Uint8::from_const_char(fabricInfo.GetFabricLabel().data()), fabricInfo.GetFabricLabel().size());
fabricDescriptor.rootPublicKey = fabricInfo.GetRootPubkey();
ReturnErrorOnFailure(encoder.Encode(fabricDescriptor));
}
return CHIP_NO_ERROR;
});
}


This issue was generated by todo based on a TODO comment in 81b6320 when #10459 was merged. cc @yufengwangca.
@todo todo bot added the todo label Oct 14, 2021
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 21, 2021
woody-apple pushed a commit that referenced this issue Oct 21, 2021
…ING (#10745)

* Fix various OCTET_STRING bits that should be CHAR_STRING.

Fixes #5542
Fixes #6112
Fixes #7112
Fixes #7322
Fixes #7654
Fixes #7655
Fixes #8704
Fixes #8705
Fixes #8706
Fixes #8707
Fixes #9797
Fixes #9798
Fixes #10508
Fixes #10509

* Regenerate generated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant