-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA Server] change "location" parameter code once CHAR_STRING is supported #7112
Comments
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Oct 21, 2021
Fixes project-chip#5542 Fixes project-chip#6112 Fixes project-chip#7112 Fixes project-chip#7322 Fixes project-chip#7654 Fixes project-chip#7655 Fixes project-chip#8704 Fixes project-chip#8705 Fixes project-chip#8706 Fixes project-chip#8707 Fixes project-chip#9797 Fixes project-chip#9798 Fixes project-chip#10508 Fixes project-chip#10509
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Oct 21, 2021
Fixes project-chip#5542 Fixes project-chip#6112 Fixes project-chip#7112 Fixes project-chip#7322 Fixes project-chip#7654 Fixes project-chip#7655 Fixes project-chip#8704 Fixes project-chip#8705 Fixes project-chip#8706 Fixes project-chip#8707 Fixes project-chip#9797 Fixes project-chip#9798 Fixes project-chip#10508 Fixes project-chip#10509
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Oct 21, 2021
Fixes project-chip#7112 Also fixes missing return if the metadata size was wrong, which would lead to us trying to process the command anyway.
woody-apple
pushed a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Oct 21, 2021
Fixes project-chip#7112 Also fixes missing return if the metadata size was wrong, which would lead to us trying to process the command anyway.
bzbarsky-apple
added a commit
that referenced
this issue
Oct 22, 2021
* Enforce spec limit on the location in OTA QueryImage. Fixes #7112 Also fixes missing return if the metadata size was wrong, which would lead to us trying to process the command anyway. * Update src/app/clusters/ota-provider/ota-provider.cpp Co-authored-by: Trevor Holbrook <[email protected]> Co-authored-by: Trevor Holbrook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
emberAfOtaSoftwareUpdateServerClusterQueryImageCallback()
contains some bandaid code to get the length of thelocation
parameter, since it is being generated asuint8_t*
instead ofSpan
:(This was added in #6476)
This may need to happen in the same PR as when
CHAR_STRING
is supported, since it may not compile afterwards.Proposed Solution
After CHAR_STRING is supported,
location
should be aSpan
object, and thesize()
method can be used instead.The text was updated successfully, but these errors were encountered: