Define ACL cluster XML #11204
Assignees
Labels
acl
Access Control feature
Comments
hubTab
pushed a commit
to hubTab/connectedhomeip
that referenced
this issue
Nov 8, 2021
project-chip#11204 project-chip#11286 Annotated the operational-credentials-cluster.xml and onoff-cluster.xml based on the Matter Specs, section 11.18, and appclusters, respectively. Normalized the <access> elements. Note that the writeable <attribute> attribute indicates if a field is writeable, or not. The <access> elements qualifies provileges on a per operation basis. updated all <struct> elements to include <item> fieldId; updated NodeOperationalCertStatus to include missing item elements; updated NOCStruct to include a missing item element; Normalized fabric_idx usage across the two updated cluster xml files.
mlepage-google
added a commit
to mlepage-google/connectedhomeip
that referenced
this issue
Nov 25, 2021
andy31415
pushed a commit
that referenced
this issue
Nov 26, 2021
* Add access control cluster xml Issue #11204 * Zap regeneration * Update src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> * Update src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> * Update src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> * Remove lengths from array attributes Apparently length is not required, which is good, because it can vary by implementation. * Remove ACL-cluster.xml from zcl.json Later will add its replacement (access-control-cluster.xml). * Fix duplicate attribute description in XML Introduced by a code review suggestion, fixed now. * Fix nullable attribute in XML Introduced by a code review suggestion, fixed now. * Fix fabric index type in xml s/fabric-idx/fabric_idx/g Silently generates the wrong code if it's wrong. Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
mlepage-google
added a commit
that referenced
this issue
Dec 4, 2021
Add access control cluster and server skeleton - Define cluster XML, ZAP, etc. - Add empty cluster implementation to all-clusters-app example. - Disabled some tests of the cluster (since its attributes are not implemented). Issue #11204 Testing: Built and ran and ensured it's present in chip-all-cluster-app. Ran unit tests.
|
XML is in main branch. It could still use a few more tweaks (e.g. list lengths, nullability) once support for complex lists of this nature is improved, but it's there. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Access Control cluster XML cluster definition should exist and match spec to allow cluster code generation
The text was updated successfully, but these errors were encountered: