Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access control cluster xml #12274

Merged
merged 11 commits into from
Nov 26, 2021
Merged

Access control cluster xml #12274

merged 11 commits into from
Nov 26, 2021

Conversation

mlepage-google
Copy link
Contributor

Problem

Remove old ACL cluster XML, add new AccessControl cluster XML.

Change overview

Provide XML for Access Control cluster.

Testing

Zap regeneration (really just removed old ACL stuff)
Built

@github-actions
Copy link

github-actions bot commented Nov 25, 2021 •
edited
Loading

PR #12274: Size comparison from 15929eb to fcfa7b1

Increases (1 build for esp32)
platform target config section 15929eb fcfa7b1 change % change
esp32 all-clusters-app m5stack (read only) 907139 907143 4 0.0
.flash.text 901755 901759 4 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 15929eb fcfa7b1 change % change
efr32 lighting-app BRD4161A (read only) 759568 759568 0 0.0
(read/write) 119812 119812 0 0.0
.bss 117988 117988 0 0.0
.data 1820 1820 0 0.0
.text 759560 759560 0 0.0
BRD4161A+rpc (read only) 747236 747236 0 0.0
(read/write) 136436 136436 0 0.0
.bss 134492 134492 0 0.0
.data 1944 1944 0 0.0
.text 747228 747228 0 0.0
lock-app BRD4161A (read only) 735504 735504 0 0.0
(read/write) 117524 117524 0 0.0
.bss 115748 115748 0 0.0
.data 1776 1776 0 0.0
.text 735496 735496 0 0.0
window-app BRD4161A (read only) 738960 738960 0 0.0
(read/write) 117884 117884 0 0.0
.bss 116100 116100 0 0.0
.data 1784 1784 0 0.0
.text 738952 738952 0 0.0
esp32 all-clusters-app c3devkit (read only) 835796 835796 0 0.0
(read/write) 1224250 1224250 0 0.0
.dram0.bss 59120 59120 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165776 165776 0 0.0
.flash.text 835796 835796 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907139 907143 4 0.0
(read/write) 423492 423492 0 0.0
.dram0.bss 64512 64512 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193628 193628 0 0.0
.flash.text 901755 901759 4 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 721348 721348 0 0.0
.bss 78276 78276 0 0.0
.data 1956 1956 0 0.0
.text 635316 635316 0 0.0
lock-app k32w061+debug (read/write) 611668 611668 0 0.0
.bss 68716 68716 0 0.0
.data 1920 1920 0 0.0
.text 535232 535232 0 0.0
shell k32w061+debug (read/write) 676972 676972 0 0.0
.bss 79868 79868 0 0.0
.data 1892 1892 0 0.0
.text 589412 589412 0 0.0
linux all-clusters-app debug (read only) 1770537 1770537 0 0.0
(read/write) 131480 131480 0 0.0
.bss 60080 60080 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138453 138453 0 0.0
.text 1493714 1493714 0 0.0
bridge-app debug+rpc (read only) 1346365 1346365 0 0.0
(read/write) 77824 77824 0 0.0
.bss 41712 41712 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113084 113084 0 0.0
.text 1133189 1133189 0 0.0
chip-tool debug (read only) 6070205 6070205 0 0.0
(read/write) 199728 199728 0 0.0
.bss 40064 40064 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 151712 151712 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 290408 290408 0 0.0
.text 5391077 5391077 0 0.0
lighting-app debug+rpc (read only) 1619433 1619433 0 0.0
(read/write) 111072 111072 0 0.0
.bss 47408 47408 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131377 131377 0 0.0
.text 1350338 1350338 0 0.0
ota-provider-app debug (read only) 1309361 1309361 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114736 114736 0 0.0
.text 1094274 1094274 0 0.0
ota-requestor-app debug (read only) 1405849 1405849 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126208 126208 0 0.0
.text 1176498 1176498 0 0.0
shell debug (read only) 820129 820129 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 78927 78927 0 0.0
.text 634514 634514 0 0.0
tv-app debug (read only) 1916225 1916225 0 0.0
(read/write) 320088 320088 0 0.0
.bss 250168 250168 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61368 61368 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159432 159432 0 0.0
.text 1608594 1608594 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293680 2293680 0 0.0
.bss 181668 181668 0 0.0
.data 5240 5240 0 0.0
.heap 849536 849536 0 0.0
.text 1256280 1256280 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2277712 2277712 0 0.0
.bss 172284 172284 0 0.0
.data 5600 5600 0 0.0
.heap 858560 858560 0 0.0
.text 1240312 1240312 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252096 2252096 0 0.0
.bss 171100 171100 0 0.0
.data 5584 5584 0 0.0
.heap 859760 859760 0 0.0
.text 1214696 1214696 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050584 2050584 0 0.0
.bss 156304 156304 0 0.0
.data 4984 4984 0 0.0
.heap 875160 875160 0 0.0
.text 1013184 1013184 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 873643 873643 0 0.0
bss 112644 112644 0 0.0
rodata 96788 96788 0 0.0
text 588544 588544 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 836203 836203 0 0.0
bss 108996 108996 0 0.0
rodata 88036 88036 0 0.0
text 562844 562844 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 798666 798666 0 0.0
bss 114020 114020 0 0.0
rodata 92044 92044 0 0.0
text 518004 518004 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 845799 845799 0 0.0
bss 109680 109680 0 0.0
rodata 92792 92792 0 0.0
text 567856 567856 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771070 771070 0 0.0
bss 111088 111088 0 0.0
rodata 88080 88080 0 0.0
text 497412 497412 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 851899 851899 0 0.0
bss 109816 109816 0 0.0
rodata 94500 94500 0 0.0
text 572040 572040 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845491 845491 0 0.0
bss 109712 109712 0 0.0
rodata 92748 92748 0 0.0
text 567476 567476 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778319 778319 0 0.0
bss 109180 109180 0 0.0
rodata 72988 72988 0 0.0
text 521552 521552 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693374 693374 0 0.0
bss 110164 110164 0 0.0
rodata 67632 67632 0 0.0
text 442160 442160 0 0.0
p6 all-clusters-app default (read/write) 2310568 2310568 0 0.0
.bss 114664 114664 0 0.0
.data 2544 2544 0 0.0
.heap 916136 916136 0 0.0
.text 1268832 1268832 0 0.0
lock-app default (read/write) 2222400 2222400 0 0.0
.bss 100960 100960 0 0.0
.data 2416 2416 0 0.0
.heap 929968 929968 0 0.0
.text 1180664 1180664 0 0.0
qpg lighting-app qpg6100+debug (read only) 501148 501148 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50384 50384 0 0.0
.data 1024 1024 0 0.0
.text 495828 495828 0 0.0
lock-app qpg6100+debug (read only) 475116 475116 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49256 49256 0 0.0
.data 980 980 0 0.0
.text 469796 469796 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 775246 775246 0 0.0
bss 79216 79216 0 0.0
noinit 37160 37160 0 0.0
text 539022 539022 0 0.0

mlepage-google and others added 4 commits November 25, 2021 15:11
@mlepage-google @tcarmelveilleux
Update src/app/zap-templates/zcl/data-model/chip/access-control-clust…
17a686e 
…er.xml

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
@mlepage-google @tcarmelveilleux
Update src/app/zap-templates/zcl/data-model/chip/access-control-clust…
d4361cf 
…er.xml

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
@mlepage-google @tcarmelveilleux
Update src/app/zap-templates/zcl/data-model/chip/access-control-clust…
8c6d1ed 
…er.xml

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
@mlepage-google
Remove lengths from array attributes
233087b 
Apparently length is not required, which is good, because it can vary by
implementation.
@github-actions
Copy link

github-actions bot commented Nov 25, 2021 •
edited
Loading

PR #12274: Size comparison from cc9dc33 to 5acd372

Full report (7 builds for k32w, qpg, telink)
platform target config section cc9dc33 5acd372 change % change
k32w lighting-app k32w061+se05x+release (read/write) 723076 723076 0 0.0
.bss 78292 78292 0 0.0
.data 1956 1956 0 0.0
.text 637028 637028 0 0.0
lock-app k32w061+debug (read/write) 612148 612148 0 0.0
.bss 68740 68740 0 0.0
.data 1920 1920 0 0.0
.text 535688 535688 0 0.0
shell k32w061+debug (read/write) 677468 677468 0 0.0
.bss 79892 79892 0 0.0
.data 1892 1892 0 0.0
.text 589884 589884 0 0.0
qpg lighting-app qpg6100+debug (read only) 502868 502868 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50400 50400 0 0.0
.data 1024 1024 0 0.0
.text 497548 497548 0 0.0
lock-app qpg6100+debug (read only) 475568 475568 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 980 980 0 0.0
.text 470248 470248 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 777178 777178 0 0.0
bss 79236 79236 0 0.0
noinit 37160 37160 0 0.0
text 540608 540608 0 0.0

@mlepage-google
Remove ACL-cluster.xml from zcl.json
4a7d653 
Later will add its replacement (access-control-cluster.xml).
@mlepage-google mlepage-google force-pushed the access-control-cluster-xml branch from 5acd372 to 4a7d653 Compare November 25, 2021 21:09
@mlepage-google
Fix duplicate attribute description in XML
f46c6a9 
Introduced by a code review suggestion, fixed now.
@mlepage-google
Fix nullable attribute in XML
5b13c13 
Introduced by a code review suggestion, fixed now.
@mlepage-google
Merge branch 'master' into access-control-cluster-xml
fb05448
@andy31415
Copy link
Contributor

fast track: xml change only, written by a domain owner

@github-actions
Copy link

github-actions bot commented Nov 25, 2021 •
edited
Loading

PR #12274: Size comparison from 23fad89 to fb05448

Increases (1 build for esp32)
platform target config section 23fad89 fb05448 change % change
esp32 all-clusters-app m5stack (read only) 907795 907799 4 0.0
.flash.text 902411 902415 4 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 23fad89 fb05448 change % change
efr32 lighting-app BRD4161A (read only) 761944 761944 0 0.0
(read/write) 119836 119836 0 0.0
.bss 118012 118012 0 0.0
.data 1820 1820 0 0.0
.text 761936 761936 0 0.0
BRD4161A+rpc (read only) 749604 749604 0 0.0
(read/write) 136460 136460 0 0.0
.bss 134516 134516 0 0.0
.data 1944 1944 0 0.0
.text 749596 749596 0 0.0
lock-app BRD4161A (read only) 735896 735896 0 0.0
(read/write) 117540 117540 0 0.0
.bss 115764 115764 0 0.0
.data 1776 1776 0 0.0
.text 735888 735888 0 0.0
window-app BRD4161A (read only) 738968 738968 0 0.0
(read/write) 117972 117972 0 0.0
.bss 116188 116188 0 0.0
.data 1784 1784 0 0.0
.text 738960 738960 0 0.0
esp32 all-clusters-app c3devkit (read only) 836408 836408 0 0.0
(read/write) 1224370 1224370 0 0.0
.dram0.bss 59144 59144 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165864 165864 0 0.0
.flash.text 836408 836408 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907795 907799 4 0.0
(read/write) 423596 423596 0 0.0
.dram0.bss 64536 64536 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193708 193708 0 0.0
.flash.text 902411 902415 4 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 723076 723076 0 0.0
.bss 78292 78292 0 0.0
.data 1956 1956 0 0.0
.text 637028 637028 0 0.0
lock-app k32w061+debug (read/write) 612148 612148 0 0.0
.bss 68740 68740 0 0.0
.data 1920 1920 0 0.0
.text 535688 535688 0 0.0
shell k32w061+debug (read/write) 677468 677468 0 0.0
.bss 79892 79892 0 0.0
.data 1892 1892 0 0.0
.text 589884 589884 0 0.0
linux all-clusters-app debug (read only) 1774009 1774009 0 0.0
(read/write) 131544 131544 0 0.0
.bss 60144 60144 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138773 138773 0 0.0
.text 1496866 1496866 0 0.0
bridge-app debug+rpc (read only) 1348333 1348333 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113404 113404 0 0.0
.text 1134837 1134837 0 0.0
chip-tool debug (read only) 6078965 6078965 0 0.0
(read/write) 199920 199920 0 0.0
.bss 40064 40064 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 151888 151888 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 290984 290984 0 0.0
.text 5398853 5398853 0 0.0
lighting-app debug+rpc (read only) 1627977 1627977 0 0.0
(read/write) 111104 111104 0 0.0
.bss 47440 47440 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131697 131697 0 0.0
.text 1358562 1358562 0 0.0
ota-provider-app debug (read only) 1309361 1309361 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114736 114736 0 0.0
.text 1094274 1094274 0 0.0
ota-requestor-app debug (read only) 1405801 1405801 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126208 126208 0 0.0
.text 1176450 1176450 0 0.0
shell debug (read only) 820129 820129 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 78927 78927 0 0.0
.text 634514 634514 0 0.0
tv-app debug (read only) 1918209 1918209 0 0.0
(read/write) 320152 320152 0 0.0
.bss 250232 250232 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61368 61368 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159752 159752 0 0.0
.text 1610258 1610258 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294536 2294536 0 0.0
.bss 181884 181884 0 0.0
.data 5240 5240 0 0.0
.heap 849320 849320 0 0.0
.text 1257136 1257136 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279808 2279808 0 0.0
.bss 172492 172492 0 0.0
.data 5600 5600 0 0.0
.heap 858352 858352 0 0.0
.text 1242408 1242408 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252888 2252888 0 0.0
.bss 171308 171308 0 0.0
.data 5584 5584 0 0.0
.heap 859552 859552 0 0.0
.text 1215488 1215488 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050840 2050840 0 0.0
.bss 156496 156496 0 0.0
.data 4984 4984 0 0.0
.heap 874968 874968 0 0.0
.text 1013440 1013440 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 875371 875371 0 0.0
bss 112660 112660 0 0.0
rodata 97092 97092 0 0.0
text 589980 589980 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 837947 837947 0 0.0
bss 109012 109012 0 0.0
rodata 88340 88340 0 0.0
text 564284 564284 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 800410 800410 0 0.0
bss 114036 114036 0 0.0
rodata 92348 92348 0 0.0
text 519444 519444 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 846315 846315 0 0.0
bss 109700 109700 0 0.0
rodata 92876 92876 0 0.0
text 568252 568252 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771590 771590 0 0.0
bss 111108 111108 0 0.0
rodata 88168 88168 0 0.0
text 497804 497804 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 852275 852275 0 0.0
bss 109836 109836 0 0.0
rodata 94588 94588 0 0.0
text 572296 572296 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845395 845395 0 0.0
bss 109712 109712 0 0.0
rodata 92748 92748 0 0.0
text 567380 567380 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778319 778319 0 0.0
bss 109180 109180 0 0.0
rodata 72988 72988 0 0.0
text 521552 521552 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693374 693374 0 0.0
bss 110164 110164 0 0.0
rodata 67632 67632 0 0.0
text 442160 442160 0 0.0
p6 all-clusters-app default (read/write) 2311048 2311048 0 0.0
.bss 114688 114688 0 0.0
.data 2544 2544 0 0.0
.heap 916112 916112 0 0.0
.text 1269312 1269312 0 0.0
lock-app default (read/write) 2222872 2222872 0 0.0
.bss 100976 100976 0 0.0
.data 2416 2416 0 0.0
.heap 929952 929952 0 0.0
.text 1181136 1181136 0 0.0
qpg lighting-app qpg6100+debug (read only) 502868 502868 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50400 50400 0 0.0
.data 1024 1024 0 0.0
.text 497548 497548 0 0.0
lock-app qpg6100+debug (read only) 475568 475568 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 980 980 0 0.0
.text 470248 470248 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 777178 777178 0 0.0
bss 79236 79236 0 0.0
noinit 37160 37160 0 0.0
text 540608 540608 0 0.0

@mlepage-google
Copy link
Contributor Author

Linux tsan error is:

Error: fatal: unable to access 'https://git.savannah.nongnu.org/git/lwip/': Failed to connect to git.savannah.nongnu.org port 443: Connection timed out
Error: fatal: clone of 'https://git.savannah.nongnu.org/git/lwip' into submodule path '/__w/connectedhomeip/connectedhomeip/third_party/p6/p6_sdk/libs/lwip' failed
Failed to clone 'third_party/p6/p6_sdk/libs/lwip' a second time, aborting
Error: The process '/usr/bin/git' failed with exit code 1

@mlepage-google
Copy link
Contributor Author

QEMU / ESP32 error is:

E (11527) task_wdt: Task watchdog got triggered. The following tasks did not reset the watchdog in time:
E (11527) task_wdt: - IDLE (CPU 0)
E (11527) task_wdt: Tasks currently running:
E (11527) task_wdt: CPU 0: main
E (11527) task_wdt: CPU 1: IDLE
E (11527) task_wdt: Print CPU 0 (current core) backtrace

@mlepage-google
Fix fabric index type in xml
519ad0b 
s/fabric-idx/fabric_idx/g

Silently generates the wrong code if it's wrong.
@github-actions
Copy link

github-actions bot commented Nov 26, 2021 •
edited
Loading

PR #12274: Size comparison from 31e64bb to 519ad0b

Increases (1 build for esp32)
platform target config section 31e64bb 519ad0b change % change
esp32 all-clusters-app m5stack (read only) 907823 907827 4 0.0
.flash.text 902439 902443 4 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 31e64bb 519ad0b change % change
efr32 lighting-app BRD4161A (read only) 762072 762072 0 0.0
(read/write) 119836 119836 0 0.0
.bss 118012 118012 0 0.0
.data 1820 1820 0 0.0
.text 762064 762064 0 0.0
BRD4161A+rpc (read only) 749740 749740 0 0.0
(read/write) 136460 136460 0 0.0
.bss 134516 134516 0 0.0
.data 1944 1944 0 0.0
.text 749732 749732 0 0.0
lock-app BRD4161A (read only) 736032 736032 0 0.0
(read/write) 117540 117540 0 0.0
.bss 115764 115764 0 0.0
.data 1776 1776 0 0.0
.text 736024 736024 0 0.0
window-app BRD4161A (read only) 739096 739096 0 0.0
(read/write) 117972 117972 0 0.0
.bss 116188 116188 0 0.0
.data 1784 1784 0 0.0
.text 739088 739088 0 0.0
esp32 all-clusters-app c3devkit (read only) 836426 836426 0 0.0
(read/write) 1224474 1224474 0 0.0
.dram0.bss 59144 59144 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165968 165968 0 0.0
.flash.text 836426 836426 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907823 907827 4 0.0
(read/write) 423692 423692 0 0.0
.dram0.bss 64536 64536 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193804 193804 0 0.0
.flash.text 902439 902443 4 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 723208 723208 0 0.0
.bss 78292 78292 0 0.0
.data 1956 1956 0 0.0
.text 637160 637160 0 0.0
lock-app k32w061+debug (read/write) 612280 612280 0 0.0
.bss 68740 68740 0 0.0
.data 1920 1920 0 0.0
.text 535820 535820 0 0.0
shell k32w061+debug (read/write) 677600 677600 0 0.0
.bss 79892 79892 0 0.0
.data 1892 1892 0 0.0
.text 590016 590016 0 0.0
linux all-clusters-app debug (read only) 1774185 1774185 0 0.0
(read/write) 131544 131544 0 0.0
.bss 60144 60144 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138869 138869 0 0.0
.text 1496946 1496946 0 0.0
bridge-app debug+rpc (read only) 1348509 1348509 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113500 113500 0 0.0
.text 1134917 1134917 0 0.0
chip-tool debug (read only) 6079157 6079157 0 0.0
(read/write) 199920 199920 0 0.0
.bss 40064 40064 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 151888 151888 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 291080 291080 0 0.0
.text 5398949 5398949 0 0.0
lighting-app debug+rpc (read only) 1628153 1628153 0 0.0
(read/write) 111104 111104 0 0.0
.bss 47440 47440 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131793 131793 0 0.0
.text 1358642 1358642 0 0.0
ota-provider-app debug (read only) 1309537 1309537 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114832 114832 0 0.0
.text 1094354 1094354 0 0.0
ota-requestor-app debug (read only) 1405977 1405977 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126304 126304 0 0.0
.text 1176530 1176530 0 0.0
shell debug (read only) 820321 820321 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79023 79023 0 0.0
.text 634610 634610 0 0.0
tv-app debug (read only) 1918385 1918385 0 0.0
(read/write) 320152 320152 0 0.0
.bss 250232 250232 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61368 61368 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159848 159848 0 0.0
.text 1610338 1610338 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294632 2294632 0 0.0
.bss 181884 181884 0 0.0
.data 5240 5240 0 0.0
.heap 849320 849320 0 0.0
.text 1257232 1257232 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279912 2279912 0 0.0
.bss 172492 172492 0 0.0
.data 5600 5600 0 0.0
.heap 858352 858352 0 0.0
.text 1242512 1242512 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253056 2253056 0 0.0
.bss 171308 171308 0 0.0
.data 5584 5584 0 0.0
.heap 859552 859552 0 0.0
.text 1215656 1215656 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2050936 0 0.0
.bss 156496 156496 0 0.0
.data 4984 4984 0 0.0
.heap 874968 874968 0 0.0
.text 1013536 1013536 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 875499 875499 0 0.0
bss 112660 112660 0 0.0
rodata 97188 97188 0 0.0
text 590004 590004 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 838059 838059 0 0.0
bss 109012 109012 0 0.0
rodata 88436 88436 0 0.0
text 564308 564308 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 800538 800538 0 0.0
bss 114036 114036 0 0.0
rodata 92444 92444 0 0.0
text 519468 519468 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 846427 846427 0 0.0
bss 109700 109700 0 0.0
rodata 92972 92972 0 0.0
text 568276 568276 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771698 771698 0 0.0
bss 111108 111108 0 0.0
rodata 88260 88260 0 0.0
text 497828 497828 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 852399 852399 0 0.0
bss 109836 109836 0 0.0
rodata 94680 94680 0 0.0
text 572320 572320 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845507 845507 0 0.0
bss 109712 109712 0 0.0
rodata 92844 92844 0 0.0
text 567404 567404 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778447 778447 0 0.0
bss 109180 109180 0 0.0
rodata 73084 73084 0 0.0
text 521576 521576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693482 693482 0 0.0
bss 110164 110164 0 0.0
rodata 67724 67724 0 0.0
text 442184 442184 0 0.0
p6 all-clusters-app default (read/write) 2311176 2311176 0 0.0
.bss 114688 114688 0 0.0
.data 2544 2544 0 0.0
.heap 916112 916112 0 0.0
.text 1269440 1269440 0 0.0
lock-app default (read/write) 2222992 2222992 0 0.0
.bss 100976 100976 0 0.0
.data 2416 2416 0 0.0
.heap 929952 929952 0 0.0
.text 1181256 1181256 0 0.0
qpg lighting-app qpg6100+debug (read only) 502992 502992 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50400 50400 0 0.0
.data 1024 1024 0 0.0
.text 497672 497672 0 0.0
lock-app qpg6100+debug (read only) 475692 475692 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 980 980 0 0.0
.text 470372 470372 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 777286 777286 0 0.0
bss 79236 79236 0 0.0
noinit 37160 37160 0 0.0
text 540616 540616 0 0.0

@andy31415 andy31415 merged commit d126aac into project-chip:master Nov 26, 2021
@mlepage-google mlepage-google deleted the access-control-cluster-xml branch November 26, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlepage-google @andy31415 @tcarmelveilleux