Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access control server skeleton #12296

Merged
merged 36 commits into from
Dec 4, 2021
Merged

Add access control server skeleton #12296

merged 36 commits into from
Dec 4, 2021

Conversation

mlepage-google
Copy link
Contributor

@mlepage-google mlepage-google commented Nov 26, 2021 •
edited
Loading

Problem

Access Control Cluster not yet created.

Change overview

Define cluster XML, ZAP, etc.
Add empty cluster implementation to all-clusters-app example.
Disabled some tests of the cluster (since its attributes are not implemented).

Testing

Built and ran and ensured it's present in chip-all-cluster-app. Ran unit tests.

@mlepage-google
Add access control server skeleton
d5eb767 
Add empty cluster implementation to all-clusters-app example.
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12296: Size comparison from a5513c2 to 08c41e9

Increases above 0.2%:

platform target config section a5513c2 08c41e9 change % change
efr32 lighting-app BRD4161A .data 1812 1828 16 0.9
BRD4161A+rpc .data 1920 1936 16 0.8
lock-app BRD4161A .data 1768 1784 16 0.9
window-app BRD4161A .data 1776 1792 16 0.9
esp32 all-clusters-app c3devkit .flash.rodata 167360 167696 336 0.2
linux all-clusters-app debug .data 1104 1120 16 1.4
.data.rel.ro 66624 66912 288 0.4
bridge-app debug+rpc (read/write) 73808 74032 224 0.3
.data 1680 1728 48 2.9
.data.rel.ro 31056 31248 192 0.6
chip-tool debug (read only) 6589629 6614125 24496 0.4
.data 1008 1024 16 1.6
.rodata 306104 306872 768 0.3
.text 5874181 5897333 23152 0.4
lighting-app debug+rpc .data 1264 1280 16 1.3
.data.rel.ro 58560 58752 192 0.3
ota-provider-app debug .data 912 928 16 1.8
ota-requestor-app debug .data 976 992 16 1.6
shell debug .data 240 256 16 6.7
tv-app debug .data 1504 1520 16 1.1
.data.rel.ro 63248 63440 192 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5168 5184 16 0.3
lighting-app CY8CPROTO_062_4343W+release .data 5480 5496 16 0.3
lock-app CY8CPROTO_062_4343W+release .data 5480 5496 16 0.3
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 99112 99372 260 0.3
nrf52840dk_nrf52840+rpc rodata 90472 90732 260 0.3
nrf5340dk_nrf5340_cpuapp rodata 94372 94628 256 0.3
lock-app nrf52840dk_nrf52840 rodata 94852 95108 256 0.3
nrf5340dk_nrf5340_cpuapp rodata 90140 90400 260 0.3
pump-app nrf52840dk_nrf52840 rodata 96584 96844 260 0.3
pump-controller-app nrf52840dk_nrf52840 rodata 94720 94980 260 0.3
p6 light-app default .data 2328 2336 8 0.3
lock-app default .data 2288 2296 8 0.3
Increases (31 builds for efr32, esp32, linux, mbed, nrfconnect, p6, telink)
platform target config section a5513c2 08c41e9 change % change
efr32 lighting-app BRD4161A (read only) 750760 751416 656 0.1
(read/write) 119976 119992 16 0.0
.data 1812 1828 16 0.9
.text 750752 751408 656 0.1
BRD4161A+rpc (read only) 779416 780064 648 0.1
(read/write) 138280 138296 16 0.0
.data 1920 1936 16 0.8
.text 779408 780056 648 0.1
lock-app BRD4161A (read only) 724616 725272 656 0.1
(read/write) 117680 117696 16 0.0
.data 1768 1784 16 0.9
.text 724608 725264 656 0.1
window-app BRD4161A (read only) 727928 728584 656 0.1
(read/write) 118104 118120 16 0.0
.data 1776 1792 16 0.9
.text 727920 728576 656 0.1
esp32 all-clusters-app c3devkit (read only) 846930 847392 462 0.1
(read/write) 1223314 1223666 352 0.0
.dram0.data 14036 14052 16 0.1
.flash.rodata 167360 167696 336 0.2
.flash.text 846930 847392 462 0.1
m5stack (read only) 917483 918035 552 0.1
(read/write) 422308 422652 344 0.1
.dram0.data 34000 34016 16 0.0
.flash.rodata 195180 195508 328 0.2
.flash.text 912099 912651 552 0.1
linux all-clusters-app debug (read only) 1832833 1835769 2936 0.2
(read/write) 123648 123936 288 0.2
.data 1104 1120 16 1.4
.data.rel.ro 66624 66912 288 0.4
.rodata 146261 146517 256 0.2
.text 1545202 1547426 2224 0.1
bridge-app debug+rpc (read only) 1416061 1417773 1712 0.1
(read/write) 73808 74032 224 0.3
.data 1680 1728 48 2.9
.data.rel.ro 31056 31248 192 0.6
.rodata 119300 119524 224 0.2
.text 1193189 1194245 1056 0.1
chip-tool debug (read only) 6589629 6614125 24496 0.4
(read/write) 201616 201936 320 0.2
.data 1008 1024 16 1.6
.data.rel.ro 160696 161016 320 0.2
.rodata 306104 306872 768 0.3
.text 5874181 5897333 23152 0.4
lighting-app debug+rpc (read only) 1699865 1701561 1696 0.1
(read/write) 106896 107088 192 0.2
.data 1264 1280 16 1.3
.data.rel.ro 58560 58752 192 0.3
.rodata 139089 139313 224 0.2
.text 1419458 1420498 1040 0.1
ota-provider-app debug (read only) 1377977 1378297 320 0.0
.data 912 928 16 1.8
.rodata 120776 120808 32 0.0
.text 1153394 1153682 288 0.0
ota-requestor-app debug (read only) 1478033 1478321 288 0.0
.data 976 992 16 1.6
.text 1238066 1238354 288 0.0
shell debug (read only) 812841 813129 288 0.0
.data 240 256 16 6.7
.text 623250 623538 288 0.0
tv-app debug (read only) 1993585 1995281 1696 0.1
(read/write) 316536 316760 224 0.1
.data 1504 1520 16 1.1
.data.rel.ro 63248 63440 192 0.3
.rodata 169128 169352 224 0.1
.text 1672562 1673602 1040 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2308000 2308840 840 0.0
.data 5168 5184 16 0.3
.text 1270576 1271416 840 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2294648 2295096 448 0.0
.data 5480 5496 16 0.3
.text 1257248 1257696 448 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2267744 2268128 384 0.0
.data 5480 5496 16 0.3
.text 1230344 1230728 384 0.0
shell CY8CPROTO_062_4343W+release .data 4864 4872 8 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 890887 891339 452 0.1
rodata 99112 99372 260 0.3
text 602512 602696 184 0.0
nrf52840dk_nrf52840+rpc (read/write) 854247 854715 468 0.1
rodata 90472 90732 260 0.3
text 577508 577692 184 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 816786 817250 464 0.1
rodata 94372 94628 256 0.3
text 532852 533036 184 0.0
lock-app nrf52840dk_nrf52840 (read/write) 861715 862163 448 0.1
rodata 94852 95108 256 0.3
text 580764 580948 184 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787866 788318 452 0.1
rodata 90140 90400 260 0.3
text 511196 511380 184 0.0
pump-app nrf52840dk_nrf52840 (read/write) 867759 868211 452 0.1
rodata 96584 96844 260 0.3
text 584832 585016 184 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 860823 861275 452 0.1
rodata 94720 94980 260 0.3
text 579892 580076 184 0.0
shell nrf52840dk_nrf52840 (read/write) 779903 779911 8 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694946 694954 8 0.0
p6 all-clusters-app default (read/write) 2337560 2338496 936 0.0
.bss 107696 107704 8 0.0
.text 1295824 1296760 936 0.1
light-app default (read/write) 2277344 2278000 656 0.0
.bss 98428 98436 8 0.0
.data 2328 2336 8 0.3
.text 1235608 1236264 656 0.1
lock-app default (read/write) 2252680 2253352 672 0.0
.bss 97084 97092 8 0.0
.data 2288 2296 8 0.3
.text 1210944 1211616 672 0.1
telink lighting-app tlsr9518adk80d (read/write) 793890 794382 492 0.1
text 554246 554444 198 0.0
Decreases (7 builds for mbed, p6)
platform target config section a5513c2 08c41e9 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851760 851744 -16 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 857760 857744 -16 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 858944 858928 -16 -0.0
shell CY8CPROTO_062_4343W+release .heap 874880 874872 -8 -0.0
p6 all-clusters-app default .heap 923192 923184 -8 -0.0
light-app default .heap 932584 932568 -16 -0.0
lock-app default .heap 933968 933952 -16 -0.0
Full report (33 builds for efr32, esp32, linux, mbed, nrfconnect, p6, telink)
platform target config section a5513c2 08c41e9 change % change
efr32 lighting-app BRD4161A (read only) 750760 751416 656 0.1
(read/write) 119976 119992 16 0.0
.bss 118160 118160 0 0.0
.data 1812 1828 16 0.9
.text 750752 751408 656 0.1
BRD4161A+rpc (read only) 779416 780064 648 0.1
(read/write) 138280 138296 16 0.0
.bss 136360 136360 0 0.0
.data 1920 1936 16 0.8
.text 779408 780056 648 0.1
lock-app BRD4161A (read only) 724616 725272 656 0.1
(read/write) 117680 117696 16 0.0
.bss 115912 115912 0 0.0
.data 1768 1784 16 0.9
.text 724608 725264 656 0.1
window-app BRD4161A (read only) 727928 728584 656 0.1
(read/write) 118104 118120 16 0.0
.bss 116328 116328 0 0.0
.data 1776 1792 16 0.9
.text 727920 728576 656 0.1
esp32 all-clusters-app c3devkit (read only) 846930 847392 462 0.1
(read/write) 1223314 1223666 352 0.0
.dram0.bss 56456 56456 0 0.0
.dram0.data 14036 14052 16 0.1
.flash.rodata 167360 167696 336 0.2
.flash.text 846930 847392 462 0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 917483 918035 552 0.1
(read/write) 422308 422652 344 0.1
.dram0.bss 61848 61848 0 0.0
.dram0.data 34000 34016 16 0.0
.flash.rodata 195180 195508 328 0.2
.flash.text 912099 912651 552 0.1
.iram0.text 122943 122943 0 0.0
linux all-clusters-app debug (read only) 1832833 1835769 2936 0.2
(read/write) 123648 123936 288 0.2
.bss 50640 50640 0 0.0
.data 1104 1120 16 1.4
.data.rel.ro 66624 66912 288 0.4
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 146261 146517 256 0.2
.text 1545202 1547426 2224 0.1
bridge-app debug+rpc (read only) 1416061 1417773 1712 0.1
(read/write) 73808 74032 224 0.3
.bss 36048 36048 0 0.0
.data 1680 1728 48 2.9
.data.rel.ro 31056 31248 192 0.6
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 119300 119524 224 0.2
.text 1193189 1194245 1056 0.1
chip-tool debug (read only) 6589629 6614125 24496 0.4
(read/write) 201616 201936 320 0.2
.bss 34344 34344 0 0.0
.data 1008 1024 16 1.6
.data.rel.ro 160696 161016 320 0.2
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 306104 306872 768 0.3
.text 5874181 5897333 23152 0.4
lighting-app debug+rpc (read only) 1699865 1701561 1696 0.1
(read/write) 106896 107088 192 0.2
.bss 41744 41744 0 0.0
.data 1264 1280 16 1.3
.data.rel.ro 58560 58752 192 0.3
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139089 139313 224 0.2
.text 1419458 1420498 1040 0.1
ota-provider-app debug (read only) 1377977 1378297 320 0.0
(read/write) 72264 72264 0 0.0
.bss 38624 38624 0 0.0
.data 912 928 16 1.8
.data.rel.ro 27592 27592 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120776 120808 32 0.0
.text 1153394 1153682 288 0.0
ota-requestor-app debug (read only) 1478033 1478321 288 0.0
(read/write) 76160 76160 0 0.0
.bss 40736 40736 0 0.0
.data 976 992 16 1.6
.data.rel.ro 29304 29304 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132720 132720 0 0.0
.text 1238066 1238354 288 0.0
shell debug (read only) 812841 813129 288 0.0
(read/write) 60264 60264 0 0.0
.bss 16904 16904 0 0.0
.data 240 256 16 6.7
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623250 623538 288 0.0
tv-app debug (read only) 1993585 1995281 1696 0.1
(read/write) 316536 316760 224 0.1
.bss 246112 246112 0 0.0
.data 1504 1520 16 1.1
.data.rel.ro 63248 63440 192 0.3
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 169128 169352 224 0.1
.text 1672562 1673602 1040 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308000 2308840 840 0.0
.bss 179516 179516 0 0.0
.data 5168 5184 16 0.3
.heap 851760 851744 -16 -0.0
.text 1270576 1271416 840 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294648 2295096 448 0.0
.bss 173208 173208 0 0.0
.data 5480 5496 16 0.3
.heap 857760 857744 -16 -0.0
.text 1257248 1257696 448 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2267744 2268128 384 0.0
.bss 172024 172024 0 0.0
.data 5480 5496 16 0.3
.heap 858944 858928 -16 -0.0
.text 1230344 1230728 384 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046576 2046576 0 0.0
.bss 156704 156704 0 0.0
.data 4864 4872 8 0.2
.heap 874880 874872 -8 -0.0
.text 1009176 1009176 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 890887 891339 452 0.1
bss 113712 113712 0 0.0
rodata 99112 99372 260 0.3
text 602512 602696 184 0.0
nrf52840dk_nrf52840+rpc (read/write) 854247 854715 468 0.1
bss 110060 110060 0 0.0
rodata 90472 90732 260 0.3
text 577508 577692 184 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 816786 817250 464 0.1
bss 115084 115084 0 0.0
rodata 94372 94628 256 0.3
text 532852 533036 184 0.0
lock-app nrf52840dk_nrf52840 (read/write) 861715 862163 448 0.1
bss 110748 110748 0 0.0
rodata 94852 95108 256 0.3
text 580764 580948 184 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787866 788318 452 0.1
bss 112160 112160 0 0.0
rodata 90140 90400 260 0.3
text 511196 511380 184 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 867759 868211 452 0.1
bss 110884 110884 0 0.0
rodata 96584 96844 260 0.3
text 584832 585016 184 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 860823 861275 452 0.1
bss 110764 110764 0 0.0
rodata 94720 94980 260 0.3
text 579892 580076 184 0.0
shell nrf52840dk_nrf52840 (read/write) 779903 779911 8 0.0
bss 109696 109696 0 0.0
rodata 73796 73796 0 0.0
text 521924 521924 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694946 694954 8 0.0
bss 110680 110680 0 0.0
rodata 68436 68436 0 0.0
text 442528 442528 0 0.0
p6 all-clusters-app default (read/write) 2337560 2338496 936 0.0
.bss 107696 107704 8 0.0
.data 2456 2456 0 0.0
.heap 923192 923184 -8 -0.0
.text 1295824 1296760 936 0.1
light-app default (read/write) 2277344 2278000 656 0.0
.bss 98428 98436 8 0.0
.data 2328 2336 8 0.3
.heap 932584 932568 -16 -0.0
.text 1235608 1236264 656 0.1
lock-app default (read/write) 2252680 2253352 672 0.0
.bss 97084 97092 8 0.0
.data 2288 2296 8 0.3
.heap 933968 933952 -16 -0.0
.text 1210944 1211616 672 0.1
telink lighting-app tlsr9518adk80d (read/write) 793890 794382 492 0.1
bss 80288 80288 0 0.0
noinit 37160 37160 0 0.0
text 554246 554444 198 0.0

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

PR #12296: Size comparison from 541ebfc to 6a5b6f8

Decreases (1 build for telink)
platform target config section 541ebfc 6a5b6f8 change % change
telink lighting-app tlsr9518adk80d (read/write) 794430 792718 -1712 -0.2
text 554474 552988 -1486 -0.3
Full report (1 build for telink)
platform target config section 541ebfc 6a5b6f8 change % change
telink lighting-app tlsr9518adk80d (read/write) 794430 792718 -1712 -0.2
bss 80304 80304 0 0.0
noinit 37160 37160 0 0.0
text 554474 552988 -1486 -0.3

@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12296: Size comparison from 803f3b8 to 5ac7f6a

Increases (4 builds for esp32, mbed, p6)
platform target config section 803f3b8 5ac7f6a change % change
esp32 all-clusters-app c3devkit (read only) 847268 847600 332 0.0
(read/write) 1223618 1223682 64 0.0
.flash.rodata 167632 167696 64 0.0
.flash.text 847268 847600 332 0.0
m5stack (read only) 917827 918171 344 0.0
(read/write) 422596 422668 72 0.0
.flash.rodata 195436 195508 72 0.0
.flash.text 912443 912787 344 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2308576 2308968 392 0.0
.text 1271152 1271544 392 0.0
p6 all-clusters-app default (read/write) 2338416 2338688 272 0.0
.text 1296680 1296952 272 0.0
Full report (31 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 803f3b8 5ac7f6a change % change
efr32 lighting-app BRD4161A (read only) 751432 751432 0 0.0
(read/write) 120008 120008 0 0.0
.bss 118176 118176 0 0.0
.data 1828 1828 0 0.0
.text 751424 751424 0 0.0
BRD4161A+rpc (read only) 780080 780080 0 0.0
(read/write) 138312 138312 0 0.0
.bss 136376 136376 0 0.0
.data 1936 1936 0 0.0
.text 780072 780072 0 0.0
lock-app BRD4161A (read only) 725272 725272 0 0.0
(read/write) 117712 117712 0 0.0
.bss 115928 115928 0 0.0
.data 1784 1784 0 0.0
.text 725264 725264 0 0.0
window-app BRD4161A (read only) 728600 728600 0 0.0
(read/write) 118136 118136 0 0.0
.bss 116344 116344 0 0.0
.data 1792 1792 0 0.0
.text 728592 728592 0 0.0
esp32 all-clusters-app c3devkit (read only) 847268 847600 332 0.0
(read/write) 1223618 1223682 64 0.0
.dram0.bss 56472 56472 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167632 167696 64 0.0
.flash.text 847268 847600 332 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 917827 918171 344 0.0
(read/write) 422596 422668 72 0.0
.dram0.bss 61864 61864 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195436 195508 72 0.0
.flash.text 912443 912787 344 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728608 728608 0 0.0
.bss 79280 79280 0 0.0
.data 1860 1860 0 0.0
.text 641668 641668 0 0.0
lock-app k32w061+debug (read/write) 617592 617592 0 0.0
.bss 69720 69720 0 0.0
.data 1824 1824 0 0.0
.text 540248 540248 0 0.0
shell k32w061+debug (read/write) 683460 683460 0 0.0
.bss 81376 81376 0 0.0
.data 1796 1796 0 0.0
.text 594488 594488 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308576 2308968 392 0.0
.bss 179532 179532 0 0.0
.data 5184 5184 0 0.0
.heap 851728 851728 0 0.0
.text 1271152 1271544 392 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295096 2295096 0 0.0
.bss 173224 173224 0 0.0
.data 5496 5496 0 0.0
.heap 857728 857728 0 0.0
.text 1257696 1257696 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2268128 2268128 0 0.0
.bss 172040 172040 0 0.0
.data 5496 5496 0 0.0
.heap 858912 858912 0 0.0
.text 1230728 1230728 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046576 2046576 0 0.0
.bss 156704 156704 0 0.0
.data 4872 4872 0 0.0
.heap 874872 874872 0 0.0
.text 1009176 1009176 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891323 891323 0 0.0
bss 113728 113728 0 0.0
rodata 99372 99372 0 0.0
text 602684 602684 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 854699 854699 0 0.0
bss 110076 110076 0 0.0
rodata 90732 90732 0 0.0
text 577680 577680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817234 817234 0 0.0
bss 115100 115100 0 0.0
rodata 94628 94628 0 0.0
text 533024 533024 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 862179 862179 0 0.0
bss 110764 110764 0 0.0
rodata 95108 95108 0 0.0
text 580936 580936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788334 788334 0 0.0
bss 112176 112176 0 0.0
rodata 90400 90400 0 0.0
text 511368 511368 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868195 868195 0 0.0
bss 110900 110900 0 0.0
rodata 96844 96844 0 0.0
text 585004 585004 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861275 861275 0 0.0
bss 110780 110780 0 0.0
rodata 94980 94980 0 0.0
text 580064 580064 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779911 779911 0 0.0
bss 109696 109696 0 0.0
rodata 73796 73796 0 0.0
text 521916 521916 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694938 694938 0 0.0
bss 110680 110680 0 0.0
rodata 68436 68436 0 0.0
text 442520 442520 0 0.0
p6 all-clusters-app default (read/write) 2338416 2338688 272 0.0
.bss 107720 107720 0 0.0
.data 2456 2456 0 0.0
.heap 923168 923168 0 0.0
.text 1296680 1296952 272 0.0
light-app default (read/write) 2278016 2278016 0 0.0
.bss 98452 98452 0 0.0
.data 2336 2336 0 0.0
.heap 932552 932552 0 0.0
.text 1236280 1236280 0 0.0
lock-app default (read/write) 2253368 2253368 0 0.0
.bss 97108 97108 0 0.0
.data 2296 2296 0 0.0
.heap 933936 933936 0 0.0
.text 1211632 1211632 0 0.0
qpg lighting-app qpg6100+debug (read only) 510408 510408 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80240 80240 0 0.0
.data 964 964 0 0.0
.text 505088 505088 0 0.0
lock-app qpg6100+debug (read only) 483232 483232 0 0.0
(read/write) 122332 122332 0 0.0
.bss 79152 79152 0 0.0
.data 916 916 0 0.0
.text 477912 477912 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794430 794430 0 0.0
bss 80304 80304 0 0.0
noinit 37160 37160 0 0.0
text 554474 554474 0 0.0

@mlepage-google
Add AccessControl cluster to Darwin test helper
ea2d4df 
Until the tests use Descriptor cluster, they have a hardcoded list of
clusters expected on endpoints, which must be kept accurate.
@mlepage-google
Remove AccessControl cluster from some tests
c8a905a 
Some Darwin tests are not relevant for this cluster (as for others).
@mlepage-google
Fix unless in test file
6eec4e3 
Those special tags need to be closed.
@mlepage-google
Merge branch 'master' into access-control-server-skeleton
4334838
@mlepage-google
Restyle and regen
fb1e25f
@mlepage-google mlepage-google mentioned this pull request Dec 3, 2021
Merged
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

PR #12296: Size comparison from 3a339bc to 04d074d

Decreases (1 build for telink)
platform target config section 3a339bc 04d074d change % change
telink lighting-app tlsr9518adk80d (read/write) 794794 793082 -1712 -0.2
text 554586 553100 -1486 -0.3
Full report (1 build for telink)
platform target config section 3a339bc 04d074d change % change
telink lighting-app tlsr9518adk80d (read/write) 794794 793082 -1712 -0.2
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554586 553100 -1486 -0.3

@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12296: Size comparison from 3a339bc to ccad3d2

Increases above 0.2%:

platform target config section 3a339bc ccad3d2 change % change
linux all-clusters-app debug .rodata 149589 150325 736 0.5
chip-tool debug (read only) 6593069 6617901 24832 0.4
.rodata 307512 308984 1472 0.5
.text 5881573 5904357 22784 0.4
Increases (6 builds for esp32, linux, mbed, p6)
platform target config section 3a339bc ccad3d2 change % change
esp32 all-clusters-app c3devkit (read only) 847594 847910 316 0.0
(read/write) 1222714 1222786 72 0.0
.flash.rodata 167848 167920 72 0.0
.flash.text 847594 847910 316 0.0
m5stack (read only) 918067 918391 324 0.0
(read/write) 421672 421752 80 0.0
.dram0.bss 60728 60736 8 0.0
.flash.rodata 195648 195720 72 0.0
.flash.text 912683 913007 324 0.0
linux all-clusters-app debug (read only) 1848137 1849985 1848 0.1
(read/write) 123216 123344 128 0.1
.data.rel.ro 66976 67104 128 0.2
.rodata 149589 150325 736 0.5
.text 1555490 1556578 1088 0.1
chip-tool debug (read only) 6593069 6617901 24832 0.4
(read/write) 199400 199688 288 0.1
.data.rel.ro 158168 158456 288 0.2
.rodata 307512 308984 1472 0.5
.text 5881573 5904357 22784 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2306704 2307032 328 0.0
.text 1269280 1269608 328 0.0
p6 all-clusters-app default (read/write) 2339080 2340240 1160 0.0
.text 1297344 1298504 1160 0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3a339bc ccad3d2 change % change
efr32 lighting-app BRD4161A (read only) 751784 751784 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751776 751776 0 0.0
BRD4161A+rpc (read only) 780440 780440 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780432 780432 0 0.0
lock-app BRD4161A (read only) 726592 726592 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 726584 726584 0 0.0
window-app BRD4161A (read only) 729096 729096 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 729088 729088 0 0.0
esp32 all-clusters-app c3devkit (read only) 847594 847910 316 0.0
(read/write) 1222714 1222786 72 0.0
.dram0.bss 55352 55352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167848 167920 72 0.0
.flash.text 847594 847910 316 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918067 918391 324 0.0
(read/write) 421672 421752 80 0.0
.dram0.bss 60728 60736 8 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195648 195720 72 0.0
.flash.text 912683 913007 324 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728696 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 641724 0 0.0
lock-app k32w061+debug (read/write) 618736 618736 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 541132 0 0.0
shell k32w061+debug (read/write) 684644 684644 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 595420 0 0.0
linux all-clusters-app debug (read only) 1848137 1849985 1848 0.1
(read/write) 123216 123344 128 0.1
.bss 49680 49680 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 66976 67104 128 0.2
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 149589 150325 736 0.5
.text 1555490 1556578 1088 0.1
bridge-app debug+rpc (read only) 1431021 1431021 0 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121044 121044 0 0.0
.text 1205077 1205077 0 0.0
chip-tool debug (read only) 6593069 6617901 24832 0.4
(read/write) 199400 199688 288 0.1
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158168 158456 288 0.2
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 307512 308984 1472 0.5
.text 5881573 5904357 22784 0.4
lighting-app debug+rpc (read only) 1716161 1716161 0 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 141681 141681 0 0.0
.text 1431810 1431810 0 0.0
ota-provider-app debug (read only) 1391625 1391625 0 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 121800 121800 0 0.0
.text 1165138 1165138 0 0.0
ota-requestor-app debug (read only) 1498297 1498297 0 0.0
(read/write) 76816 76816 0 0.0
.bss 40992 40992 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29592 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 134288 134288 0 0.0
.text 1255314 1255314 0 0.0
shell debug (read only) 822041 822041 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83634 83634 0 0.0
.text 631570 631570 0 0.0
tv-app debug (read only) 2029745 2029745 0 0.0
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174216 174216 0 0.0
.text 1700786 1700786 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2306704 2307032 328 0.0
.bss 178404 178404 0 0.0
.data 5184 5184 0 0.0
.heap 852856 852856 0 0.0
.text 1269280 1269608 328 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2296296 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1258896 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270224 2270224 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1232824 1232824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047408 2047408 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010008 1010008 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 891715 0 0.0
bss 113756 113756 0 0.0
rodata 99588 99588 0 0.0
text 602824 602824 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 855091 855091 0 0.0
bss 110104 110104 0 0.0
rodata 90948 90948 0 0.0
text 577820 577820 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817626 817626 0 0.0
bss 115128 115128 0 0.0
rodata 94844 94844 0 0.0
text 533164 533164 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 863655 863655 0 0.0
bss 111016 111016 0 0.0
rodata 95704 95704 0 0.0
text 581544 581544 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789794 789794 0 0.0
bss 112428 112428 0 0.0
rodata 90996 90996 0 0.0
text 511972 511972 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 868523 0 0.0
bss 110928 110928 0 0.0
rodata 97060 97060 0 0.0
text 585084 585084 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 861763 0 0.0
bss 110808 110808 0 0.0
rodata 95196 95196 0 0.0
text 580316 580316 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779907 779907 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521920 521920 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694934 694934 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442524 442524 0 0.0
p6 all-clusters-app default (read/write) 2339080 2340240 1160 0.0
.bss 106596 106596 0 0.0
.data 2464 2464 0 0.0
.heap 924280 924280 0 0.0
.text 1297344 1298504 1160 0.1
light-app default (read/write) 2279744 2279744 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1238008 1238008 0 0.0
lock-app default (read/write) 2256048 2256048 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214312 1214312 0 0.0
qpg lighting-app qpg6100+debug (read only) 510480 510480 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505160 505160 0 0.0
lock-app qpg6100+debug (read only) 484124 484124 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478804 478804 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794794 794794 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554586 554586 0 0.0

@mlepage-google
Add ignore list for cluster attribute tests
1f1b567 
Accommodate known failures in specific endpoint/cluster/attribute paths
(e.g. not yet implement).
@restyled-io restyled-io bot mentioned this pull request Dec 3, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12296: Size comparison from 3a339bc to 4f594bd

Increases above 0.2%:

platform target config section 3a339bc 4f594bd change % change
linux all-clusters-app debug .rodata 149589 150325 736 0.5
chip-tool debug (read only) 6593069 6617901 24832 0.4
.rodata 307512 308984 1472 0.5
.text 5881573 5904357 22784 0.4
Increases (3 builds for linux, p6)
platform target config section 3a339bc 4f594bd change % change
linux all-clusters-app debug (read only) 1848137 1849985 1848 0.1
(read/write) 123216 123344 128 0.1
.data.rel.ro 66976 67104 128 0.2
.rodata 149589 150325 736 0.5
.text 1555490 1556578 1088 0.1
chip-tool debug (read only) 6593069 6617901 24832 0.4
(read/write) 199400 199688 288 0.1
.data.rel.ro 158168 158456 288 0.2
.rodata 307512 308984 1472 0.5
.text 5881573 5904357 22784 0.4
p6 all-clusters-app default (read/write) 2339080 2340240 1160 0.0
.text 1297344 1298504 1160 0.1
Full report (22 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 3a339bc 4f594bd change % change
efr32 lighting-app BRD4161A (read only) 751784 751784 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751776 751776 0 0.0
BRD4161A+rpc (read only) 780440 780440 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780432 780432 0 0.0
lock-app BRD4161A (read only) 726592 726592 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 726584 726584 0 0.0
window-app BRD4161A (read only) 729096 729096 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 729088 729088 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728696 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 641724 0 0.0
lock-app k32w061+debug (read/write) 618736 618736 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 541132 0 0.0
shell k32w061+debug (read/write) 684644 684644 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 595420 0 0.0
linux all-clusters-app debug (read only) 1848137 1849985 1848 0.1
(read/write) 123216 123344 128 0.1
.bss 49680 49680 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 66976 67104 128 0.2
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 149589 150325 736 0.5
.text 1555490 1556578 1088 0.1
bridge-app debug+rpc (read only) 1431021 1431021 0 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121044 121044 0 0.0
.text 1205077 1205077 0 0.0
chip-tool debug (read only) 6593069 6617901 24832 0.4
(read/write) 199400 199688 288 0.1
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158168 158456 288 0.2
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 307512 308984 1472 0.5
.text 5881573 5904357 22784 0.4
lighting-app debug+rpc (read only) 1716161 1716161 0 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 141681 141681 0 0.0
.text 1431810 1431810 0 0.0
ota-provider-app debug (read only) 1391625 1391625 0 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 121800 121800 0 0.0
.text 1165138 1165138 0 0.0
ota-requestor-app debug (read only) 1498297 1498297 0 0.0
(read/write) 76816 76816 0 0.0
.bss 40992 40992 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29592 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 134288 134288 0 0.0
.text 1255314 1255314 0 0.0
shell debug (read only) 822041 822041 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83634 83634 0 0.0
.text 631570 631570 0 0.0
tv-app debug (read only) 2029745 2029745 0 0.0
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174216 174216 0 0.0
.text 1700786 1700786 0 0.0
p6 all-clusters-app default (read/write) 2339080 2340240 1160 0.0
.bss 106596 106596 0 0.0
.data 2464 2464 0 0.0
.heap 924280 924280 0 0.0
.text 1297344 1298504 1160 0.1
light-app default (read/write) 2279744 2279744 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1238008 1238008 0 0.0
lock-app default (read/write) 2256048 2256048 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214312 1214312 0 0.0
qpg lighting-app qpg6100+debug (read only) 510480 510480 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505160 505160 0 0.0
lock-app qpg6100+debug (read only) 484124 484124 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478804 478804 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794794 794794 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554586 554586 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 4, 2021 •
edited
Loading

PR #12296: Size comparison from 3a339bc to 127624a

Increases above 0.2%:

platform target config section 3a339bc 127624a change % change
linux all-clusters-app debug .rodata 149589 150325 736 0.5
chip-tool debug (read only) 6593069 6617901 24832 0.4
.rodata 307512 308984 1472 0.5
.text 5881573 5904357 22784 0.4
Increases (9 builds for esp32, linux, mbed, p6)
platform target config section 3a339bc 127624a change % change
esp32 all-clusters-app c3devkit (read only) 847594 847778 184 0.0
(read/write) 1222714 1222786 72 0.0
.flash.rodata 167848 167920 72 0.0
.flash.text 847594 847778 184 0.0
m5stack (read only) 918067 918323 256 0.0
(read/write) 421672 421752 80 0.0
.dram0.bss 60728 60736 8 0.0
.flash.rodata 195648 195720 72 0.0
.flash.text 912683 912939 256 0.0
linux all-clusters-app debug (read only) 1848137 1850017 1880 0.1
(read/write) 123216 123344 128 0.1
.data.rel.ro 66976 67104 128 0.2
.rodata 149589 150325 736 0.5
.text 1555490 1556610 1120 0.1
bridge-app debug+rpc (read only) 1431021 1431053 32 0.0
.text 1205077 1205109 32 0.0
chip-tool debug (read only) 6593069 6617901 24832 0.4
(read/write) 199400 199688 288 0.1
.data.rel.ro 158168 158456 288 0.2
.rodata 307512 308984 1472 0.5
.text 5881573 5904357 22784 0.4
lighting-app debug+rpc (read only) 1716161 1716193 32 0.0
.text 1431810 1431842 32 0.0
tv-app debug (read only) 2029745 2029777 32 0.0
.text 1700786 1700818 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2306704 2306968 264 0.0
.text 1269280 1269544 264 0.0
p6 all-clusters-app default (read/write) 2339080 2339952 872 0.0
.text 1297344 1298216 872 0.1
Decreases (21 builds for efr32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3a339bc 127624a change % change
efr32 lighting-app BRD4161A (read only) 751784 751480 -304 -0.0
.text 751776 751472 -304 -0.0
BRD4161A+rpc (read only) 780440 780152 -288 -0.0
.text 780432 780144 -288 -0.0
lock-app BRD4161A (read only) 726592 726304 -288 -0.0
.text 726584 726296 -288 -0.0
window-app BRD4161A (read only) 729096 728808 -288 -0.0
.text 729088 728800 -288 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728616 -80 -0.0
.text 641724 641644 -80 -0.0
lock-app k32w061+debug (read/write) 618736 618672 -64 -0.0
.text 541132 541068 -64 -0.0
shell k32w061+debug (read/write) 684644 684564 -80 -0.0
.text 595420 595340 -80 -0.0
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2296296 2296232 -64 -0.0
.text 1258896 1258832 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2270224 2270160 -64 -0.0
.text 1232824 1232760 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 891651 -64 -0.0
text 602824 602756 -68 -0.0
nrf52840dk_nrf52840+rpc (read/write) 855091 855027 -64 -0.0
text 577820 577752 -68 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817626 817546 -80 -0.0
text 533164 533092 -72 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 863655 863575 -80 -0.0
text 581544 581472 -72 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789794 789730 -64 -0.0
text 511972 511900 -72 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 868459 -64 -0.0
text 585084 585012 -72 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 861699 -64 -0.0
text 580316 580244 -72 -0.0
p6 light-app default (read/write) 2279744 2279440 -304 -0.0
.text 1238008 1237704 -304 -0.0
lock-app default (read/write) 2256048 2255744 -304 -0.0
.text 1214312 1214008 -304 -0.0
qpg lighting-app qpg6100+debug (read only) 510480 510400 -80 -0.0
.text 505160 505080 -80 -0.0
lock-app qpg6100+debug (read only) 484124 484060 -64 -0.0
.text 478804 478740 -64 -0.0
telink lighting-app tlsr9518adk80d (read/write) 794794 794658 -136 -0.0
text 554586 554454 -132 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3a339bc 127624a change % change
efr32 lighting-app BRD4161A (read only) 751784 751480 -304 -0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751776 751472 -304 -0.0
BRD4161A+rpc (read only) 780440 780152 -288 -0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780432 780144 -288 -0.0
lock-app BRD4161A (read only) 726592 726304 -288 -0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 726584 726296 -288 -0.0
window-app BRD4161A (read only) 729096 728808 -288 -0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 729088 728800 -288 -0.0
esp32 all-clusters-app c3devkit (read only) 847594 847778 184 0.0
(read/write) 1222714 1222786 72 0.0
.dram0.bss 55352 55352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167848 167920 72 0.0
.flash.text 847594 847778 184 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918067 918323 256 0.0
(read/write) 421672 421752 80 0.0
.dram0.bss 60728 60736 8 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195648 195720 72 0.0
.flash.text 912683 912939 256 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728616 -80 -0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 641644 -80 -0.0
lock-app k32w061+debug (read/write) 618736 618672 -64 -0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 541068 -64 -0.0
shell k32w061+debug (read/write) 684644 684564 -80 -0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 595340 -80 -0.0
linux all-clusters-app debug (read only) 1848137 1850017 1880 0.1
(read/write) 123216 123344 128 0.1
.bss 49680 49680 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 66976 67104 128 0.2
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 149589 150325 736 0.5
.text 1555490 1556610 1120 0.1
bridge-app debug+rpc (read only) 1431021 1431053 32 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121044 121044 0 0.0
.text 1205077 1205109 32 0.0
chip-tool debug (read only) 6593069 6617901 24832 0.4
(read/write) 199400 199688 288 0.1
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158168 158456 288 0.2
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 307512 308984 1472 0.5
.text 5881573 5904357 22784 0.4
lighting-app debug+rpc (read only) 1716161 1716193 32 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 141681 141681 0 0.0
.text 1431810 1431842 32 0.0
ota-provider-app debug (read only) 1391625 1391625 0 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 121800 121800 0 0.0
.text 1165138 1165138 0 0.0
ota-requestor-app debug (read only) 1498297 1498297 0 0.0
(read/write) 76816 76816 0 0.0
.bss 40992 40992 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29592 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 134288 134288 0 0.0
.text 1255314 1255314 0 0.0
shell debug (read only) 822041 822041 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83634 83634 0 0.0
.text 631570 631570 0 0.0
tv-app debug (read only) 2029745 2029777 32 0.0
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174216 174216 0 0.0
.text 1700786 1700818 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2306704 2306968 264 0.0
.bss 178404 178404 0 0.0
.data 5184 5184 0 0.0
.heap 852856 852856 0 0.0
.text 1269280 1269544 264 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2296232 -64 -0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1258832 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270224 2270160 -64 -0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1232824 1232760 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047408 2047408 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010008 1010008 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 891651 -64 -0.0
bss 113756 113756 0 0.0
rodata 99588 99588 0 0.0
text 602824 602756 -68 -0.0
nrf52840dk_nrf52840+rpc (read/write) 855091 855027 -64 -0.0
bss 110104 110104 0 0.0
rodata 90948 90948 0 0.0
text 577820 577752 -68 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817626 817546 -80 -0.0
bss 115128 115128 0 0.0
rodata 94844 94844 0 0.0
text 533164 533092 -72 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 863655 863575 -80 -0.0
bss 111016 111016 0 0.0
rodata 95704 95704 0 0.0
text 581544 581472 -72 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789794 789730 -64 -0.0
bss 112428 112428 0 0.0
rodata 90996 90996 0 0.0
text 511972 511900 -72 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 868459 -64 -0.0
bss 110928 110928 0 0.0
rodata 97060 97060 0 0.0
text 585084 585012 -72 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 861699 -64 -0.0
bss 110808 110808 0 0.0
rodata 95196 95196 0 0.0
text 580316 580244 -72 -0.0
shell nrf52840dk_nrf52840 (read/write) 779907 779907 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521920 521920 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694934 694934 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442524 442524 0 0.0
p6 all-clusters-app default (read/write) 2339080 2339952 872 0.0
.bss 106596 106596 0 0.0
.data 2464 2464 0 0.0
.heap 924280 924280 0 0.0
.text 1297344 1298216 872 0.1
light-app default (read/write) 2279744 2279440 -304 -0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1238008 1237704 -304 -0.0
lock-app default (read/write) 2256048 2255744 -304 -0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214312 1214008 -304 -0.0
qpg lighting-app qpg6100+debug (read only) 510480 510400 -80 -0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505160 505080 -80 -0.0
lock-app qpg6100+debug (read only) 484124 484060 -64 -0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478804 478740 -64 -0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794794 794658 -136 -0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554586 554454 -132 -0.0

@mlepage-google mlepage-google merged commit 1f484bd into project-chip:master Dec 4, 2021
@mlepage-google mlepage-google deleted the access-control-server-skeleton branch January 12, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@vijs vijs Awaiting requested review from vijs

Assignees
No one assigned
Labels
app controller darwin examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlepage-google @andy31415 @yunhanw-google @woody-apple