Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Fix invalid fn instance for Circuits with the SubCircuit crate #1081

Closed
pinkiebell opened this issue Jan 18, 2023 · 0 comments · Fixed by #1104
Closed

Fix invalid fn instance for Circuits with the SubCircuit crate #1081

pinkiebell opened this issue Jan 18, 2023 · 0 comments · Fixed by #1104
Assignees
@ed255
Labels
T-bug Type: bug

Comments

@pinkiebell
Copy link
Contributor

Revisit all sub circuits that implement the SubCircuit trait and make sure that they are properly return the correct instance.

Follow up: #1052
@ed255 ed255 added the T-bug Type: bug label Jan 25, 2023
@ed255 ed255 mentioned this issue Jan 25, 2023
Merged
@ed255 ed255 moved this to 🏗 In progress in zkEVM Community Edition Jan 25, 2023
@aguzmant103 aguzmant103 moved this from 🏗 In progress to 👀 In review in zkEVM Community Edition Jan 26, 2023
@ed255 ed255 moved this from 👀 In review to ✅ Done in zkEVM Community Edition Feb 1, 2023
SuccinctPaul pushed a commit to SuccinctPaul/zkevm-circuits that referenced this issue Feb 15, 2024
@noel2004 @kunxian-xia
[FIX] sha256 witness issue (privacy-scaling-explorations#1081) (priva…
d776b47 
…cy-scaling-explorations#1087)

* reproduce phase issues in sha256_circuit

* fix issues

* fmt and clippy

* fix gate issue

---------

Co-authored-by: kunxian xia <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ed255 ed255

Labels
T-bug Type: bug
Projects
zkEVM Community Edition
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: unify circuits in integration tests privacy-scaling-explorations/zkevm-circuits
2 participants
@ed255 @pinkiebell