Proof generation for tx circuit fails with: Error:InvalidInstances

[AronisAt79]

zkevm-chain commit: dfe9cc5717b7f248b644715b00726cc340adcce6
circuits commit: "https://github.com/pinkiebell/zkevm-circuits.git", branch = "zkevm-chain"

logs & traces: https://zkevm-chain-testing.s3.eu-central-1.amazonaws.com/proveSingeCrossChainTx_tx_False_57-maronis.tar.gz

[aguzmant103]

@ChihChengLiang will check the logs and extract useful information on how to proceed.

[ChihChengLiang]

This one has nothing traceable other than invalid instances. It would be helpful to know what inputs are fed into what circuits. cc @pinkiebell

https://github.com/privacy-scaling-explorations/zkevm-chain/blob/68982510b93fd34e06f5d2f444a3807b90668b40/prover/src/utils.rs#L63

[pinkiebell]

I think that is due the tx circuit doesn't have a proper fn instance implemented yet.

[CPerezz]

Could you fill an issue in the repo to include them?? @pinkiebell

[ed255]

I think that is due the tx circuit doesn't have a proper fn instance implemented yet.

This is correct! I fixed it here #1104

@pinkiebell Once that PR is merged, the zkevm-chain should be able to run all circuits like this:

zkevm-circuits/integration-tests/src/integration_test_circuits.rs

Lines 265 to 285 in 8d40c64

	/// Integration test generic function
	pub async fn test_circuit_at_block<C: SubCircuit<Fr> + Circuit<Fr>>(
	circuit_name: &str,
	degree: u32,
	block_num: u64,
	actual: bool,
	proving_key: Option<ProvingKey<G1Affine>>,
	) {
	log::info!("test {} circuit, block number: {}", circuit_name, block_num);
	let (builder, _) = gen_inputs(block_num).await;
	let mut block = block_convert(&builder.block, &builder.code_db).unwrap();
	block.randomness = Fr::from(TEST_MOCK_RANDOMNESS);
	let circuit = C::new_from_block(&block);
	let instance = circuit.instance();
	if actual {
	test_actual(degree, circuit, instance, proving_key);
	} else {
	test_mock(degree, &circuit, instance);
	}
	}

That function can be called for each circuit like in here: https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/feature%2Funify-integration-tests-1/integration-tests/tests/circuits.rs

[davidnevadoc]

Is this solved then? @ed255

[ed255]

Is this solved then? @ed255

In theory I think it should be resolved, but I'd prefer to wait until this is deployed in the testnet so that we can really confirm this error is not appearing anymore :)

[pinkiebell]

@AronisAt79 This can be tested with this branch https://github.com/privacy-scaling-explorations/zkevm-chain/tree/2023-01-16

[AronisAt79]

@AronisAt79 This can be tested with this branch https://github.com/privacy-scaling-explorations/zkevm-chain/tree/2023-01-16

Thanks @pinkiebell! will start the tests now.

[AronisAt79]

Testedon zkevm-chain commit 6cdd88644cfe87a7f640cc279c54a44b93bbf0fa.
Proof generation now succeeds.
Full logs: https://zkevm-chain-testing.s3.eu-central-1.amazonaws.com/proveSingeCrossChainTx_tx_True_329-timer.tar.gz