This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
fix evm circuit phase2 cells #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate-zkevm-circuits
han0110
approved these changes
Jan 19, 2023
adria0
approved these changes
Jan 20, 2023
| @@ -75,6 +75,10 @@ impl<F: Field> MemoryAddressGadget<F> { | |||
| memory_offset: Cell<F>, | |||
| memory_length: MemoryAddress<F>, | |||
| ) -> Self { | |||
| debug_assert_eq!( | |||
There was a problem hiding this comment.
I see that you add cell_column_index only for this check.
Could you add a comment about this assertion?
SuccinctPaul
pushed a commit
to SuccinctPaul/zkevm-circuits
that referenced
this pull request
Feb 15, 2024
…cy-scaling-explorations#1087) * reproduce phase issues in sha256_circuit * fix issues * fmt and clippy * fix gate issue --------- Co-authored-by: kunxian xia <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1086
(these types of bugs can be detected with this modified MockProver scroll-tech/halo2@e409a69 )