-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue upgrading to Prettier 3 #562
Comments
I got same error on reviewdog/action-golangci-lint#561 (comment) |
V5 pre-release actually adds support for this. I'm shocked this has been in September last year... @JounQin can you provide information about the future of this package? Thanks for your work! |
Same issue both for running eslint in a package.json script and vscode eslint output from the extension. Fixed by downgrading prettier to version 2.8.8 |
@sandrooco I tried version
Dependencies:
|
I realized that my problem is related to the |
as mentioned by @sandrooco, the
to:
in my |
Please use the alpha version for now, I think we need some feedback before we release the final major version. npm i -D eslint-plugin-prettier@alpha |
This comment was marked as resolved.
This comment was marked as resolved.
Thanks for your feedback @JounQin. I was able to successfully run prettier 3.0.0 with the alpha release. |
This comment was marked as resolved.
This comment was marked as resolved.
Smooth, thanks |
- cf. prettier/eslint-plugin-prettier#562 - Solution: eslint-plugin-prettier upgrade to v5
Can't build without either downgrading or upgrading. See [this issue for details](prettier/eslint-plugin-prettier#562).
## What's the purpose of this pull request? This PR fixes [this](https://github.com/vtex/faststore/actions/runs/6458890810/job/17533535581) issue that happened while publishing packages due to incompatible `eslint-plugin-prettier` versions with prettier 3.x. ## How it works? In #2050 I upgraded the prettier version to 3.x. That caused the issue because `tsdx` has a dependency on an old `eslint-plugin-prettier` version, which is incompatible with `prettier@3`. I'm rolling back the upgrade and fixing the prettier version on the major `2` which makes it difficult for others to make the same mistake as me. In the future, we remove all uses of `tsdx` as it is no longer supported and has gone 3 years without updates. ## How to test it? By merging this! ## References prettier/eslint-plugin-prettier#562 Thanks @hellofanny for noticing the error and investigating it!
I tried using alpha version and still got this error:
in the package json I have: "eslint-config-prettier": "^8.8.0", Node version: v16.20.2 Tried with version Any suggestion? What may I be missing here? |
@ivantrave it looks like |
Thanks for your comment @lehni ! For now, I downgraded to the following versions and it worked:
Thanks |
Why this issue is closed, if the error is still not resolved? For me next.js, prettier 3.0.3 and plugin 5.0.1 do not work either |
@konradbjk Then please post another issue with runnable reproduction. |
…tier Necessary updates to support Prettier update: prettier/eslint-plugin-prettier#562
* chore(deps-dev): bump prettier from 2.8.8 to 3.1.1 Bumps [prettier](https://github.com/prettier/prettier) from 2.8.8 to 3.1.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.8.8...3.1.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps-dev): update eslint-config-prettier and eslint-plugin-prettier Necessary updates to support Prettier update: prettier/eslint-plugin-prettier#562 * style: Prettier fixes --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eddybrando Vásquez <[email protected]>
Fixed after updating ESLint
|
I can confirm this works for me |
What version of
eslint
are you using?8.44.0
What version of
prettier
are you using?3.0.0
What version of
eslint-plugin-prettier
are you using?4.2.1
Please paste any applicable config files that you're using (e.g.
.prettierrc
or.eslintrc
files)What source code are you linting?
private source code
What did you expect to happen?
Can run with prettier 3 like with prettier 2
What actually happened?
The text was updated successfully, but these errors were encountered: