Add fulltext indexing to ontology store #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjstevens
force-pushed
the
ontology_store
branch
from
110c4a0
to
094f8e4
Compare
inline snapshots are not supported by jest with Prettier 3 and above
rbuels
force-pushed
the
ontology_store_fulltext
branch
from
1287b59
to
46ed7be
Compare
|
@garrettjstevens ok I think this is good to go |
|
Wow, that does make it a lot faster. I have noticed one thing, though, that can make the search results a bit unintuitive. For example, here's a search for "calcium" before this branch: And in this branch: It looks like the top terms that pop up in this branch do have "calcium" in their description, but not the label, so it's maybe not clear to the user why they show up. Maybe the indexing should rank search results with the term in the label above those with the term in the description. |
…r JSONPath for configuring text indexing fields
…ontology multi select
|
@garrettjstevens i think this is pretty good, have another look and merge if you like I did quite a bit of work to make the ranking and result display better. |
garrettjstevens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds full-text indexing to the ontology store and uses it for autocomplete.
Good results, pretty fast and effective.
This also has a Jest upgrade in it that was part of my attempts to make inline snapshots work again. Jest inline snapshots no longer work since we upgraded to prettier 3 (probably related to prettier/eslint-plugin-prettier#562, seems likely that a fix will be coming soon)