CSV upload #1109
Merged
CSV upload #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aameraryan is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Perfect, thank you so much! |
dartpain
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
Fixes the CSV file upload issue.
Additional info and screenshots are attached in the bottom.
Resolves a linting issue caused by the incompatibility between prettier 3.3.3 and eslint-plugin-prettier 4.2.1. This is a known issue. Upgrading eslint-plugin-prettier to version 5.x resolved the problem. The upgrade also required formatting the files to pass lint checks.
Note: The GitHub action was blocking commits, so the fix for eslint-plugin-prettier and the related updates were included in this PR. Please let me know if we should open a separate issue for this fix and address it before tackling the main issue.
Why was this change needed? (You can also link to an open issue here)
Other information:
Before: The file input did not support uploading .csv files. Even when users selected a .csv file, the file input did not select the file and appeared empty.
After: The file input now supports and successfully uploads .csv files.
