This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
Issue #50 and #51 : fix various bugs and add unit tests #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 23, 2020 16:54
tcleonard
changed the title
|
This will not pass the Circle CI checks as I have moved toward a Travis CI solution instead (so the integration needs to be enabled on this repository, as well as for coveralls) but as you can see the tests are green: https://travis-ci.com/github/tcleonard/graphene-federation/builds/194699031 |
|
Hello @tcleonard , This repository is going to be archived Further development of graphene-federation will be at https://github.com/graphql-python/graphene-federation Best regards |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address issues #50 and #51 (and more).
This is quite a big MR but when I tried to use the library I faced various bugs.
I added a bunch of unit-test in order to make sure I fixed all the things I have found... but it would be worth to add even more.
I have moved the CI to TravisCI as it is free (instead of using Preply Circle CI)