This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
allow fields with @requires directive to have their own inputs #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approach with this regular expression is quite fragile... I submitted a bit of a revamped approach in the pull request #52 that solve your issue (I even added your exact problem as a unit test) |
@tcleonard agree, but at moment my wish was not to rewrite it but to solve an issue, in either case PR is month old and seems like there is no activity, hopefully your contribution will be more luckily |
Hello folks , This repository is going to be archived Further development of graphene-federation will be at https://github.com/graphql-python/graphene-federation Best regards |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have something as simple as:
everything works as expected, but if we gonna need to have some inputs on our
foo
field then nothing will work, e.g.:will produce sdl where
foo
field wont have@requires
directivethats why we gonna need this
(\([^\)]*\)\s*)?
addition to regexp to allow optional argumentschange of
[\S\s]*?
is needed because previous change will start changing schema for each run and regexp wont catch next fieldsIntegration test is added to prevent regression in future