Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Regular expression to mark external fields is not working properly when defining filters using a field with the same name #50

Closed
tcleonard opened this issue Oct 20, 2020 · 2 comments

Comments

@tcleonard
Copy link

As you can see in this example when printing the annotated schema in _mark_field method:

  • the external decorator is placed correctly here:
type User  @key(fields: "id") {
  id: ID! @external
  files(before: String, after: String, first: Int, last: Int): FileConnection
}  
  • as soon as I add a filter on the files id in the connection the regular expression gets confused and place the decorator in the wrong place:
type User  @key(fields: "id") {
  id: ID!
  files(before: String, after: String, first: Int, last: Int, id: ID): @external FileConnection
}  
@chinskiy
Copy link
Member

Hello @tcleonard ,

This repository is going to be archived

Further development of graphene-federation will be at https://github.com/graphql-python/graphene-federation
Please address your further pull requests and issues there

Best regards

@tcleonard
Copy link
Author

Thanks, I know, I'm the one that maintain the project in graphql-python :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants