-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New bid adapter for Smaato #2091
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0a91bfa
Smaato: Initial version of bid adapter doc.
sbrosinski fc18e17
Smaato: Add fpd info
sbrosinski 1c7ac4e
Smaato: Adjust first party data confif example
sbrosinski 43e1adf
Smaato: Adjust adapter docs to reference correct yob and keywords
sbrosinski dce2a81
Smaato: Add video ad unit example
sbrosinski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
--- | ||
layout: bidder | ||
title: Smaato | ||
description: Prebid Smaato Bidder Adaptor | ||
hide: true | ||
biddercode: smaato | ||
gdpr_supported: true | ||
usp_supported: true | ||
coppa_supported: true | ||
media_types: banner | ||
--- | ||
|
||
### Note | ||
|
||
The Smaato adapter requires setup and approval from the Smaato team, even for existing Smaato publishers. Please reach out to your account team or [email protected] for more information. | ||
|
||
### Bid Params | ||
|
||
{: .table .table-bordered .table-striped } | ||
| Name | Scope | Description | Example | Type | | ||
|------------|----------|----------------------|------------|----------| | ||
| `publisherId` | required | Your Smaato publisher id | `'1100012345'` | `string` | | ||
| `adspaceId` | required | Your Smaato adspace id | `'11002234'` | `string` | | ||
|
||
### Example Ad Unit | ||
|
||
```javascript | ||
var adUnit = { | ||
"code": "header-bid-tag-1", | ||
"mediaTypes": { | ||
"banner": { | ||
"sizes": [320, 50] | ||
} | ||
}, | ||
"bids": [{ | ||
"bidder": "smaato", | ||
"params": { | ||
"publisherId": "1100012345", | ||
"adspaceId": "11002234" | ||
} | ||
}] | ||
} | ||
``` | ||
|
||
The Smaato adapter supports passing through first party data configured in your prebid integration. | ||
|
||
```javascript | ||
pbjs.setConfig({ | ||
fpd: { | ||
context: { | ||
keywords: ["power tools"] | ||
}, | ||
user: { | ||
keywords: ["a","b"], | ||
gender: "M", | ||
yob: "1984" | ||
} | ||
}); | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open rtb specifies
yob
as an integer... please update. I just fixed the API reference this was copied from.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was confusing me, that's why I created prebid/Prebid.js#5415 .
Is that the only change? OpenRTB also defines keywords as a string (comma seperated keywords), and in the docs context.content.userrating should be a string, not an int.
I'll change user.yob and user.keywords in smaato.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right - keywords should be comma-separate strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed all types (also in the adapter itself) to confirm to openrtb, thank you.