Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bid adapter for Smaato #2091

Merged
merged 5 commits into from
Jul 23, 2020
Merged

Conversation

sbrosinski
Copy link
Contributor

This is the accompanying PR for the doc update for a new bid adapter create for Smaato Inc.

user: {
keywords: ["a","b"],
gender: "M",
yob: "1984"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open rtb specifies yob as an integer... please update. I just fixed the API reference this was copied from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was confusing me, that's why I created prebid/Prebid.js#5415 .
Is that the only change? OpenRTB also defines keywords as a string (comma seperated keywords), and in the docs context.content.userrating should be a string, not an int.
I'll change user.yob and user.keywords in smaato.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right - keywords should be comma-separate strings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed all types (also in the adapter itself) to confirm to openrtb, thank you.

@sbrosinski sbrosinski requested a review from bretg June 30, 2020 19:12
@sbrosinski
Copy link
Contributor Author

This is ready to be merged now, once the adapter itself is reviewed, right?

@bretg bretg added LGTM and removed needs work labels Jul 6, 2020
@MartianTribe MartianTribe merged commit 4f35f04 into prebid:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants