-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New bid adapter for Smaato #2091
Conversation
dev-docs/bidders/smaato.md
Outdated
user: { | ||
keywords: ["a","b"], | ||
gender: "M", | ||
yob: "1984" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open rtb specifies yob
as an integer... please update. I just fixed the API reference this was copied from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was confusing me, that's why I created prebid/Prebid.js#5415 .
Is that the only change? OpenRTB also defines keywords as a string (comma seperated keywords), and in the docs context.content.userrating should be a string, not an int.
I'll change user.yob and user.keywords in smaato.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right - keywords should be comma-separate strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed all types (also in the adapter itself) to confirm to openrtb, thank you.
This is ready to be merged now, once the adapter itself is reviewed, right? |
This is the accompanying PR for the doc update for a new bid adapter create for Smaato Inc.