-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First party data has types which are incompatible with the OpenRTB types #5415
Comments
@sbrosinski - sorry for the confusion. This is mostly just a docs issue. I fixed
Within Prebid.js, First Party Data is entirely convention:
Things get a little harder when it comes to Prebid Server. The PBS bidAdapter copies all fields of fpd.context and fpd.user. There will be a few rules applied when they hit Prebid Server:
You're welcome to comment on the Prebid Server First Party draft. https://docs.google.com/document/d/1I2eS40yMYJCgz8XvFljf4f59bEPsbWTrUpnD7a7uJEg/edit I guess we need a separate page describing the FPD conventions. Will put that on my to-do list. Re-working the PBS docs for the next few weeks. |
@bretg thank you for the explanation. I requested access to the Prebid Server First Party google doc. I guess good docs are really needed also for the publisher. I'm not validating the root level attributes and depend on the publishers to configure the correct values/types. Once I gained some more experience with it, I'm happy also contributing to the docs. One more comment on the current attributes: OpenRTB differentiates between user.geo and device.geo. I'm assuming the root level geo from 1. will become part of user.geo. Maybe we can make clearer which geo data Prebid expects here. |
Would certainly appreciate any help you can offer with documentation @sbrosinski .
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Followups:
|
Type of issue
Enhancement
Description
So the docs for how to configure first party data states:
"The First Party Data JSON structure reflects the OpenRTB standard. Keywords, search, content, gender, yob, and geo are special values in OpenRTB."
The adapter I'm working on talks to an OpenRTB based bidder. My initial assumation based on the examples given was, that I can just call e.g.
config.getConfig('fpd.user')
and assign all keys from that object to theuser
node in my OpenRTB bid request, since I would like to have gender, yob, etc. if available.Expected results
Since the keys look like they match the OpenRTB keys for the bidRequest.user and bidRequest.site object I was assuming the values also match the expected values in OpenRTB, which is not the case.
For example
keywords
in the Prebid.js fpd.user object is shown as an array of strings, while OpenRTB asks for a string with comma seperated values. Yob is shown as a string, OpenRTB expects an integer.What I find unclear is, which values
fpd.context
andfpd.user
actually allow. Explicitly only keywords, search, content, gender, yob, geo and data? Would the completegeo
object be supported?And do the values types in the examples (e.g. as described in #3687 (comment) or http://prebid.org/dev-docs/publisher-api-reference.html#setConfig-fpd) is what is expected from the publisher and adapters which need those values for OpenRTB requests need to convert them?
That's the approach I chose for our adapter. But now I have to look at each key I want to support, check if it's there, convert from e.g. string to int, in order to build my OpenRTB bid request.
The text was updated successfully, but these errors were encountered: