Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set inventory #166

Closed
wants to merge 6 commits into from
Closed

Set inventory #166

wants to merge 6 commits into from

Conversation

AntoineJac
Copy link
Contributor

here is the feature request: #165

ppuviarasu
ppuviarasu previously approved these changes Mar 21, 2019
@ppuviarasu
Copy link
Collaborator

The changes are approved. Need the changes in Android too for us to merge and do a new release to maven & cocoapods. Will keep it open until we have the android changes and push to master when both are complete

@AntoineJac
Copy link
Contributor Author

@ppuviarasu , thanks will do the change for Android next week. There are a few points that need to be fixed also for the Android version.
Will post the Android PR has soon as I have completed all tests.
Thanks,

@ppuviarasu
Copy link
Collaborator

resolve the conflict & submit the PR

@ppuviarasu
Copy link
Collaborator

@AntoineJac The user keywords were intentionally set per adUnit and is explicitly mentioned in out I2I
#113
The reasoning if the publisher wants to set only for a specific adUnit n not for others.
The implementation was done as mentioned.
Lets keep it that level and continue the same.

@AntoineJac
Copy link
Contributor Author

AntoineJac commented Mar 27, 2019

Thanks all, let stall this until #165 has been validated and an intent to implement decided.

@AntoineJac
Copy link
Contributor Author

will use the new api for passing data

@AntoineJac AntoineJac closed this May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants