Clean the rep + swiftLint #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 18, 2019 21:19
|
@ppuviarasu and @yoalex5 , here is a PR with:
Thanks, |
ppuviarasu
reviewed
Mar 18, 2019
ppuviarasu
previously approved these changes
Mar 21, 2019
|
Can you resolve the conflicts and push in? |
|
@ppuviarasu , conflicts are solved. Can you please merge? Thanks, |
ppuviarasu
previously approved these changes
Mar 22, 2019
|
@ppuviarasu , can you please merge when ready ? |
|
checks are not passing... something is not rite... looking into it |
|
|
No... it doesnt work... I dont see the changes different in the travis file. Can you revert the same and push? |
|
@ppuviarasu , can you please merge. It is now working. Thanks. |
ppuviarasu
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used Swiftlint to clean the repo.
I have also added a swiftlint.yml rules for the PrebidMobile directory and edit the travis.
Anycode not compliant with the swiftlint.yml rules will now fail.