-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inventoy Keywords are not present #165
Comments
I have fwd this to the product manager... Will get a response and review the PR for the same. |
Hi @AntoineJac I have no problem with adding the method. Perhaps should make it a separate PR from the SwiftLint addition. We would also need to make sure the new method is added to the adUnit class documentation. |
@astephensxandr , thanks here the PR for this issue only: |
Last status: Stalled until prebid/Prebid.js#3687 has been validated @astephensxandr , I have edited also the logic of the methods. Both the user and inventory method are linked to the app level not the adUnit. The methods should be called within the Targeting class. They are passed in the app.keywords and user.keywords as stated in the openRtb document. With comma as separator. Do notice that normally only a "Comma separated list of keywords" and not keys/value are passed. But it is still possible using addKeywords() method and this allows each bidder to build its adapter to push the data according to its own specs.
Thanks, |
@astephensxandr , @ppuviarasu , @mjacobsonny |
Closing this in favor of supporting a common first party data method. |
When looking at the current adUnit api there is a method addUserKeyword (or addUserKeywords) to pass the user targeting to Prebid Server that will passed it to the different bidder as user.keywords
Prebid server is also built to pass inventory keyword to bidder as app.keywords (or site.keywords). However the method in not present in the current adUnit class.
I have run some test with curl and appending the app.keywords and all is working fine, the key value are being passed to Appnexus and Rubicon. So we only need to add the method.
This is important as some publishers want to use inventory targeting to classify their config.
Do notice that it is part of the PR: 164 that I have proposed.
@mjacobsonny , can you please confirm it is fine to add this method.
Thanks
The text was updated successfully, but these errors were encountered: