Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kusama coretime config #221

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

serban300
Copy link
Contributor

  • Does not require a CHANGELOG entry

Closes #216

Credits to @bkchr for the suggested fix

@eskimor
Copy link
Contributor

eskimor commented Mar 7, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) March 7, 2024 13:11
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@acatangiu
Copy link
Contributor

acatangiu commented Mar 7, 2024

@eskimor @sandreim I want to point you to #198 which is the only existing test at this point (indirectly) validating block production.

Without ☝️ we might have shipped this bug to Kusama and stalled parachains.

Asking for a bit of love in the shape of a review of above 😄

@eskimor
Copy link
Contributor

eskimor commented Mar 7, 2024

@eskimor @sandreim I want to point you to #198 which is the only existing test at this point (indirectly) validating block production.

Without ☝️ we might have shipped this bug to Kusama and stalled parachains.

Asking for a bit of love in the shape of a review of above 😄

If I am not completely mistaken, the above fix only fixes Zombienet tests. It should have no effect on production - which is why it was set to (). But indeed, running the runtime in Zombienet should be the bare minimum we should do for a release!

@fellowship-merge-bot fellowship-merge-bot bot merged commit 36a7ea1 into polkadot-fellows:main Mar 8, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zombienet: KusamaAssetHub and KusamaBridgeHub are not producing blocks
4 participants