Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zombienet: KusamaAssetHub and KusamaBridgeHub are not producing blocks #216

Closed
serban300 opened this issue Mar 5, 2024 · 9 comments · Fixed by #221
Closed

Zombienet: KusamaAssetHub and KusamaBridgeHub are not producing blocks #216

serban300 opened this issue Mar 5, 2024 · 9 comments · Fixed by #221

Comments

@serban300
Copy link
Contributor

serban300 commented Mar 5, 2024

KusamaAssetHub and KusamaBridgeHub are not producing blocks when started in zombienet

Using a git blame like approach, I reached this commit as the one who introduced the issue: 59172d5

The zombienet test that I'm using: https://github.com/polkadot-fellows/runtimes/blob/acf1797c84cc14935ccfd8d34043ef5e20a3de08/integration-tests/bridges/environments/polkadot-kusama/bridge_hub_kusama_local_network.toml

@bkontur
Copy link
Contributor

bkontur commented Mar 5, 2024

I don't see anything suspicious e.g. for AssetHubKusama lib.rs and also for chain-spec-generator there is just encointer-related change.

just a blind guess, try add more collators (3-4)?

@bkontur
Copy link
Contributor

bkontur commented Mar 5, 2024

Relay chain produces blocks? I don't know, isn't there anything in the logs?

@serban300
Copy link
Contributor Author

Yes, relay chain produces blocks. I don't see anything worth mentioning in the logs

@bkontur
Copy link
Contributor

bkontur commented Mar 5, 2024

so I would guess that it could be related to the coretime stuff maybe:
59172d5#diff-efa4caeb17487ecb13d8f5eb7863c3241d84afa2e73fbf25909a2ca89df0f362

because this was introduced in that commit just for Kusama, so maybe some coretime magic should happen?
@seadanda @eskimor any ideas?

@serban300
Copy link
Contributor Author

Yes, it works if I undo the coretime-related changes

@seadanda @eskimor can you PTAL ?

@eskimor
Copy link
Contributor

eskimor commented Mar 8, 2024

Can we make these Zombienet tests part of the CI?

@serban300
Copy link
Contributor Author

@eskimor I don't know. Personally I would totally support this. But I think we should open a separate discussion for this, and maybe include the CI team. For the moment I see there is no zombienet test in this repo and I think the entire infrastructure that is needed for this is missing (building and pushing docker images for example). I don't know if it's by design or if it just wasn't prioritized.

But as a first step I think it would bring value to include the bridge zombienet test as it is and run it manually. And add it in the CI later depending on the separate discussion.

@eskimor
Copy link
Contributor

eskimor commented Mar 8, 2024

Done: #226

fellowship-merge-bot bot added a commit that referenced this issue Mar 8, 2024
<!-- Remember that you can run `/merge` to enable auto-merge in the PR
-->

<!-- Remember to modify the changelog. If you don't need to modify it,
you can check the following box.
Instead, if you have already modified it, simply delete the following
line. -->

- [x] Does not require a CHANGELOG entry

Closes #216

Credits to @bkchr for the suggested fix

Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
@serban300
Copy link
Contributor Author

Closed by #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants