-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add P<>K bridge manual zombienet test for asset transfer #198
Merged
fellowship-merge-bot
merged 5 commits into
polkadot-fellows:main
from
serban300:bridge-zombienet-packaging
May 1, 2024
Merged
Add P<>K bridge manual zombienet test for asset transfer #198
fellowship-merge-bot
merged 5 commits into
polkadot-fellows:main
from
serban300:bridge-zombienet-packaging
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
force-pushed
the
bridge-zombienet-packaging
branch
2 times, most recently
from
February 27, 2024 13:53
81831b0
to
acf1797
Compare
svyatonik
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
acatangiu
approved these changes
Mar 6, 2024
/merge |
Enabled Available commands
For more information see the documentation |
auto-merge was automatically disabled
May 1, 2024 11:58
Head branch was pushed to by a user without write access
serban300
force-pushed
the
bridge-zombienet-packaging
branch
from
May 1, 2024 11:58
154e9d9
to
e840ed1
Compare
/merge |
fellowship-merge-bot
bot
merged commit May 1, 2024
6d5a7a1
into
polkadot-fellows:main
36 checks passed
Enabled Available commands
For more information see the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a P<>K bridge zombienet test which checks the following:
The test is meant to be ran manually as per the instructions in the
README.md
and is based on the naive bridge testing "orchestrator" defined in thepolkadot-sdk
repo: https://github.com/paritytech/polkadot-sdk/tree/master/bridges/testing . The "orchestrator" is downloaded usinggit sparse checkout
directly from thepolkadot-sdk
repo (I couldn't find a better way to package thebash
andjs
files on which the test depends).Proposing to add the test in this repo as per the feedback from the bridges team and since this way it would be more convenient to run it before a release or when performing a change to the bridge hubs for example. If there are concerns about this, the second option would be to add it to the
parity-bridges-common
repo.Closes: paritytech/polkadot-sdk#3400