Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-navigation and initial landing page #886

Closed
deboer-tim opened this issue Oct 4, 2024 · 0 comments · Fixed by #936
Closed

Sub-navigation and initial landing page #886

deboer-tim opened this issue Oct 4, 2024 · 0 comments · Fixed by #936
Assignees
@deboer-tim

Comments

@deboer-tim
Copy link
Contributor

As a precursor to #863, we need sub-navigation in the bootc extension and (so that we have more than one page) we will start with the current welcome.

  • Add sub navigation.
  • Move current welcome to a dedicated (the default) page
  • Add a more traditional empty screen (ideally still with actions) to the disk images page.
@deboer-tim deboer-tim self-assigned this Oct 4, 2024
@nichjones1 nichjones1 moved this to 📋 Backlog in Podman Desktop Planning Oct 8, 2024
@cdrage cdrage mentioned this issue Oct 9, 2024
Closed
@deboer-tim deboer-tim moved this from 📋 Backlog to 🚧 In Progress in Podman Desktop Planning Oct 16, 2024
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Oct 16, 2024
@deboer-tim
feat: navigation and dashboard
d2390e0 
Introduces left navigation for bootc. The initial Dashboard is just the empty screen
that we had before (but now always visible), and Disk Images is the main screen we
had after you had created an image, renamed and with a more typical empty screen.
This sets bootc up for adding additional pages in the future, most likely Samples
and a filtered bootable Images page.

Most page urls had to be updated, and I switched to vi.waitFor() for the tests I
updated.

Most of podman-desktop#886, but not marking as fixed since there is some renaming & cleanup
that I'd like to do on other files but didn't want to complicate this PR further.

Signed-off-by: Tim deBoer <[email protected]>
@deboer-tim deboer-tim mentioned this issue Oct 16, 2024
Merged
deboer-tim added a commit that referenced this issue Oct 17, 2024
@deboer-tim
feat: navigation and dashboard
6f9366a 
Introduces left navigation for bootc. The initial Dashboard is just the empty screen
that we had before (but now always visible), and Disk Images is the main screen we
had after you had created an image, renamed and with a more typical empty screen.
This sets bootc up for adding additional pages in the future, most likely Samples
and a filtered bootable Images page.

Most page urls had to be updated, and I switched to vi.waitFor() for the tests I
updated.

Most of #886, but not marking as fixed since there is some renaming & cleanup
that I'd like to do on other files but didn't want to complicate this PR further.

Signed-off-by: Tim deBoer <[email protected]>
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Oct 17, 2024
@deboer-tim
chore: rename bootc to disk-image
0a4524b 
Move the disk image related files into the disk-image folder, and rename using
the same pattern we use for columns in Podman Desktop. While I was there I updated
most imports to '/@' syntax.

Also thought of another test for the Navigation and added that.

Fixes podman-desktop#886.

Signed-off-by: Tim deBoer <[email protected]>
This was referenced Oct 17, 2024
Merged
Closed
@github-project-automation github-project-automation bot moved this from 🚧 In Progress to ✔️ Done in Podman Desktop Planning Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deboer-tim deboer-tim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: rename bootc to disk-image deboer-tim/podman-desktop-extension-bootc
1 participant
@deboer-tim