-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: navigation and dashboard #934
feat: navigation and dashboard #934
Conversation
Introduces left navigation for bootc. The initial Dashboard is just the empty screen that we had before (but now always visible), and Disk Images is the main screen we had after you had created an image, renamed and with a more typical empty screen. This sets bootc up for adding additional pages in the future, most likely Samples and a filtered bootable Images page. Most page urls had to be updated, and I switched to vi.waitFor() for the tests I updated. Most of podman-desktop#886, but not marking as fixed since there is some renaming & cleanup that I'd like to do on other files but didn't want to complicate this PR further. Signed-off-by: Tim deBoer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the UI. Can you elaborate how we are keeping track of disk images?
I wonder whether we should have a default directory for creating disk images and keep track of which OCI image was used to create them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Threw me off for a second thinking a lot of code was changed, but it was because EmptyScreen was deleted and re-created.
Heavily tested this out with POC of #895
Code LGTM.
Unfortunately we just keep a historical list of built images atm, which can get out of sync if you also do things outside of the extension. There has been discussion about disk images getting stored as OCI artifacts which we'd really like to support at some point as a proper repo - but seems likely we'll always have local files too.
Each time you build the output folder is pre-filled with the last folder you used, but you can pick a different folder any time. Either way we always store the output folder, which OCI image was used, architecture, etc. so we don't really need a fixed default folder.
Yes, we could do that. We could also periodically scan to see if the generated images are still where you built them and either automatically remove them, show some 'validation', or allow you to 'import' other images. Either way, none of this is directly related to this issue 🙂 so I've opened #935, maybe we can continue the discussion there, or you can open a new issue for anything I've missed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way, none of this is directly related to this issue 🙂 so I've opened #935, maybe we can continue the discussion there, or you can open a new issue for anything I've missed.
Let's do this. Thank you!
Great work, LGTM
What does this PR do?
Introduces left navigation for bootc. The initial Dashboard is just the empty screen that we had before (but now always visible), and Disk Images is the main screen we had after you had created an image, renamed and with a more typical empty screen. This sets bootc up for adding additional pages in the future, most likely Samples and a filtered bootable Images page.
Most page urls had to be updated, and I switched to vi.waitFor() for the tests I updated.
Screenshot / video of UI
Screen.Recording.2024-10-16.at.2.12.41.PM.mov
What issues does this PR fix or reference?
Most of #886, but not marking as fixed since there is some renaming & cleanup that I'd like to do on other files but didn't want to complicate this PR further.
How to test this PR?
Unit tests updated. Go to every page and try all links to confirm navigation.