feat: read language from metadata (resolves #129) #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatislander
changed the title
jhung
approved these changes
Mar 11, 2020
| @endif | ||
| @foreach($terms as $term => $name) | ||
| <li class="tag"> | ||
| <button class="button button--tag-button" data-checkbox="{{ $taxonomy }}-{{ $term }}"><span class="screen-reader-text">{{ __('Remove', 'coop-library') }} </span>{!! $name !!}<span class="screen-reader-text"> {{ __('from current filters', 'coop-library') }}</span> @svg('close', 'icon--close', ['focusable' => 'false', 'aria-hidden' => 'true'])</button> |
There was a problem hiding this comment.
Issue #208 affects this label as well.
NVDA will read the label as "Remove alllanguages" (with the effect of slurring the two words together). Inspecting the accessibility shows that the label is properly structured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for resource languages stored in metadata (see platform-coop-toolkit/coop-library-framework#316) and the ability to filter resources by language. It also preserves accordion status on filter application, resolving #129.
Steps to test
Expected behavior: Resources in all languages are shown, and they can be filtered by language.
Additional information
Not applicable.
Related issues