Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all saved searches button requires non-breaking space for NVDA, which adds subtle right padding #208

Closed
greatislander opened this issue Mar 2, 2020 · 2 comments · Fixed by #234
Closed

Remove all saved searches button requires non-breaking space for NVDA, which adds subtle right padding #208

greatislander opened this issue Mar 2, 2020 · 2 comments · Fixed by #234
Assignees
@greatislander
Labels
bug Something isn't working
Milestone
1.0.0-rc.1

Comments

@greatislander
Copy link
Collaborator

Describe the bug

See #193 (comment)
@greatislander greatislander added the bug Something isn't working label Mar 2, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Mar 2, 2020
@greatislander greatislander self-assigned this Mar 2, 2020
@jhung jhung mentioned this issue Mar 11, 2020
Merged
2 tasks
@jhung
Copy link
Contributor

jhung commented Mar 11, 2020

The "Deselect All Languages" label is affected by this issue as well.

The accessibility tree shows a proper label, but NVDA appears to incorrectly pronounce the label with a span.

@jhung
Copy link
Contributor

jhung commented Mar 12, 2020

The solution @greatislander and I discussed was to create separate accessible text that provides a complete phrase instead of just a fragment.

This means that there will be a label for sighted use cases, and another label for accessibility. This will make it better for translations as translating full phrases is better than translating fragments.

greatislander added a commit that referenced this issue Mar 28, 2020
@greatislander
fix: use different text for screen reader button labels (fix #208)
88ebb69
@greatislander greatislander mentioned this issue Mar 28, 2020
Merged
2 tasks
greatislander pushed a commit that referenced this issue Mar 28, 2020
fix: use different text for screen reader button labels (#234)
5884c78 
Fixes #208.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

fix: use different text for screen reader button labels platform-coop-toolkit/coop-library
2 participants
@jhung @greatislander