Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use different text for screen reader button labels #234

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

greatislander
Copy link
Collaborator

Description

Resolves #208.

Steps to test

  1. Test "Remove all" (favorites), "Remove all" (saved searches), and "Deselect all" (filters) buttons in screen readers.

Expected behavior: Screen readers should announce expanded labels for these buttons.

Additional information

Not applicable.

Related issues

@greatislander greatislander requested a review from jhung March 28, 2020 15:02
@greatislander greatislander self-assigned this Mar 28, 2020
@greatislander greatislander added the enhancement New feature or request label Mar 28, 2020
@greatislander greatislander added this to the 1.0.0-rc.1 milestone Mar 28, 2020
@greatislander greatislander changed the title fix: use different text for screen reader button labels (fix #208) fix: use different text for screen reader button labels Mar 28, 2020
@greatislander greatislander merged commit 5884c78 into dev Mar 28, 2020
@greatislander greatislander deleted the fix/screen-reader-buttons branch March 28, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all saved searches button requires non-breaking space for NVDA, which adds subtle right padding
1 participant