Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When applying filters to resource list, open accordions should remain open upon reload #129

Closed
jhung opened this issue Jan 14, 2020 · 0 comments · Fixed by #216
Closed

When applying filters to resource list, open accordions should remain open upon reload #129

jhung opened this issue Jan 14, 2020 · 0 comments · Fixed by #216
Assignees
@greatislander
Labels
enhancement New feature or request
Milestone
1.0.0-alpha.2

Comments

@jhung
Copy link
Contributor

jhung commented Jan 14, 2020

Describe the bug
When applying a filter, any expanded accordions are collapsed on reload causing a disconnect with the user's action and the result.

To Reproduce
Steps to reproduce the behavior:

  1. View the Resource library in desktop view
  2. Go to the Resources list under "Explore" in the menu
  3. In the sidebar choose "Cities" in the sidebar
  4. Select "Apply Filters" button
  5. After the page reloads, notice that the accordion in the sidebar is now closed.

Expected behavior
When applying a filter to a resource list any accordions that were expanded should remain expanded upon reload.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Firefox
  • Version 72.0.1
@greatislander greatislander added the enhancement New feature or request label Jan 14, 2020
@greatislander greatislander added this to the 1.0.0-beta.1 milestone Mar 10, 2020
@greatislander greatislander self-assigned this Mar 10, 2020
greatislander added a commit that referenced this issue Mar 10, 2020
@greatislander
fix: preserve accordion status after form submission
5044cae 
Resolves #129
@greatislander greatislander mentioned this issue Mar 10, 2020
Merged
2 tasks
greatislander pushed a commit that referenced this issue Mar 11, 2020
feat: read language from metadata (resolves #129) (#216)
45674f2 
* feat: use new language meta field instead of taxonomy

* feat: add filtering by language

* feat: localized language labels

* fix: localization warnings

* fix: preserve accordion status after form submission

Resolves #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.2
Development

Successfully merging a pull request may close this issue.

feat: read language from metadata (resolves #129) platform-coop-toolkit/coop-library
2 participants
@jhung @greatislander