feat: add search results and saved searches (fix #115, fix #162) #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatislander
changed the title
greatislander
changed the title
greatislander
changed the title
jhung
requested changes
Mar 2, 2020
jhung
reviewed
Mar 2, 2020
| @@ -1,4 +1,4 @@ | |||
| <div class="align-right" hidden><button id="remove-all" class="button button--borderless button--destructive">@svg('delete', 'icon--delete', ['focusable' => 'false', 'aria-hidden' => 'true']) {{ __('Remove all', 'coop-library') }}​<span class="screen-reader-text">{{ __('saved searches', 'coop-library') }}</span></button></div> | |||
| <div class="align-right" hidden><button id="remove-all" class="button button--borderless button--destructive">@svg('delete', 'icon--delete', ['focusable' => 'false', 'aria-hidden' => 'true']) {{ __('Remove all', 'coop-library') }} <span class="screen-reader-text">{{ __('saved searches', 'coop-library') }}</span></button></div> | |||
There was a problem hiding this comment.
@greatislander I tested with NVDA and   worked in providing a break in the label. ​ did not work.
There was a problem hiding this comment.
Does inside the <span class="visually-hidden"> work?
There was a problem hiding this comment.
@jhung I am moving this into a separate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements layout for the search results page and saved search functionality.
TODO:
Steps to test
Search, examine results page. Apply some filters. Save a few searches, then view the saved search page.
Additional information
Not applicable.
Related issues