Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search results page #162

Closed
greatislander opened this issue Jan 23, 2020 · 0 comments · Fixed by #193
Closed

Add search results page #162

greatislander opened this issue Jan 23, 2020 · 0 comments · Fixed by #193
Assignees
@greatislander
Labels
enhancement New feature or request
Milestone
1.0.0-alpha.2

Comments

@greatislander
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Search results page needs formatting.

Describe the solution you'd like

Formatting should be nearly identical to browse view.

Describe alternatives you've considered

Not applicable.

Additional context

Not applicable.
@greatislander greatislander added the enhancement New feature or request label Jan 23, 2020
@greatislander greatislander self-assigned this Jan 23, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Jan 23, 2020
@greatislander greatislander mentioned this issue Feb 19, 2020
Merged
7 tasks
greatislander pushed a commit that referenced this issue Mar 2, 2020
@jhung
feat: add search results and saved searches (fix #115, fix #162) (#193)
b07a3ce 
* fix: use new tag buttons in current filters, use Pinecone search form

* feat: allow search results to be filtered

* fix: only search resources

* feat: add save search button and search term display

* fix: don't run code twice on search results page

* feat: saved search functionality

* fix: notification positioning

* feat: limit saved searches to 25

* feat: limit saved searches to 50 instead of 25

* fix: resolve PHPCS error

* fix: paginate search results

* fix: set post type in pre_get_posts

* Revert "fix: set post type in pre_get_posts"

434e0b2

* fix: remove all button label

https://github.com/platform-coop-toolkit/coop-library/pull/193\#discussion_r386540238

* fix: dialog titles

* fix: add space in remove all button label

* fix: try   inside span

* fix: move   outside span

Co-authored-by: jhung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.2
Development

Successfully merging a pull request may close this issue.

feat: add search results and saved searches (fix #115, fix #162) platform-coop-toolkit/coop-library
1 participant
@greatislander