Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search results and saved searches (fix #115, fix #162) #193

Merged
merged 23 commits into from
Mar 2, 2020
Merged

feat: add search results and saved searches (fix #115, fix #162) #193

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8ed90a1
fix: use new tag buttons in current filters, use Pinecone search form
greatislander Feb 18, 2020
11149a4
feat: allow search results to be filtered
greatislander Feb 19, 2020
832f1b7
fix: only search resources
greatislander Feb 19, 2020
0fbfd01
feat: add save search button and search term display
greatislander Feb 19, 2020
e81f059
Merge branch 'dev' into add/search-results
greatislander Feb 20, 2020
80b57d3
fix: don't run code twice on search results page
greatislander Feb 20, 2020
a178762
feat: saved search functionality
greatislander Feb 20, 2020
9d122b0
Merge branch 'dev' into add/search-results
greatislander Feb 20, 2020
95d50b6
fix: notification positioning
greatislander Feb 21, 2020
1bb1881
feat: limit saved searches to 25
greatislander Feb 21, 2020
fb961dc
feat: limit saved searches to 50 instead of 25
greatislander Feb 21, 2020
9549bf5
fix: resolve PHPCS error
greatislander Feb 21, 2020
e7a9600
fix: paginate search results
greatislander Feb 25, 2020
40974eb
Merge branch 'dev' into add/search-results
greatislander Feb 26, 2020
6d39d3f
Merge branch 'dev' into add/search-results
greatislander Feb 27, 2020
35ce02e
Merge branch 'dev' into add/search-results
greatislander Feb 28, 2020
434e0b2
fix: set post type in pre_get_posts
greatislander Feb 28, 2020
5dfde3d
Revert "fix: set post type in pre_get_posts"
greatislander Feb 28, 2020
2314ee7
fix: remove all button label
greatislander Mar 2, 2020
03ca0b0
fix: dialog titles
greatislander Mar 2, 2020
404bdb7
fix: add space in remove all button label
jhung Mar 2, 2020
5c3ab0d
fix: try   inside span
greatislander Mar 2, 2020
e441770
fix: move   outside span
greatislander Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/views/partials/content-page-saved-searches.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="align-right" hidden><button id="remove-all" class="button button--borderless button--destructive">@svg('delete', 'icon--delete', ['focusable' => 'false', 'aria-hidden' => 'true']) {{ __('Remove all', 'coop-library') }}​​&#8203;<span class="screen-reader-text">{{ __('saved searches', 'coop-library') }}</span></button></div>
<div class="align-right" hidden><button id="remove-all" class="button button--borderless button--destructive">@svg('delete', 'icon--delete', ['focusable' => 'false', 'aria-hidden' => 'true']) {{ __('Remove all', 'coop-library') }}​​&nbsp<span class="screen-reader-text">{{ __('saved searches', 'coop-library') }}</span></button></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greatislander I tested with NVDA and &nbsp worked in providing a break in the label. &#8203; did not work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does &nbsp; inside the <span class="visually-hidden"> work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhung I am moving this into a separate issue.

<div id="saved-searches"></div>
<div class="nothing-saved">
<p class="h2">{{__('You have no saved searches.', 'coop-library') }}</p>
Expand Down