-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: prevent invalid filter rules from being applied, which would lead to an irrecoverable changefeed failure (#2117) #2132
cli: prevent invalid filter rules from being applied, which would lead to an irrecoverable changefeed failure (#2117) #2132
Conversation
… status becomes to failed
@ben1009: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d547e74
|
Codecov Report
@@ Coverage Diff @@
## release-5.0 #2132 +/- ##
================================================
Coverage ? 53.8343%
================================================
Files ? 164
Lines ? 17656
Branches ? 0
================================================
Hits ? 9505
Misses ? 7132
Partials ? 1019 |
…d to an irrecoverable changefeed failure (pingcap#2117) (pingcap#2132)
This is an automated cherry-pick of #2117
What problem does this PR solve?
fix Changfeed rules filter is updated to be invalid format, changfeed status becomes to failed #1625
What is changed and how it works?
add a validation
verifyReplicaConfig
when load configCheck List
Tests
Code changes
Related changes
Release note