Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changfeed rules filter is updated to be invalid format, changfeed status becomes to failed #1625

Closed
Tammyxia opened this issue Apr 9, 2021 · 1 comment
Assignees
Labels
area/ticdc Issues or PRs related to TiCDC. bug-from-internal-test Bugs found by internal testing. severity/major type/bug The issue is confirmed as a bug.

Comments

@Tammyxia
Copy link

Tammyxia commented Apr 9, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
  • " tiup cdc cli changefeed update --config changfeed.toml -c replication-task-1 --pd=http://172.31.10.94:2379", update rules filter sucessfully.

  • query this changfeed, check the filter rules is :
    "filter": {
    "rules": [
    "rtest1",
    "rtest2"
    ],

  • Then the changfeed status become to failed, and cannot be resumed.
    image

  • There's no way to update filter rules to be correct format. Failed changfeed cannot be recovered.

  1. What did you expect to see?
    If config file changfeed.toml has invalid content, the update cli should be failed to execute, to avoid the changfeed become failed status and unrecoverable.

  2. What did you see instead?

  3. Versions of the cluster

    • Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

      v5.0.0-nightly, Git Commit Hash: 09a4c57d00175ae3ff9c900d5fb67f6757c58181
      
    • TiCDC version (execute cdc version):

      release-version=v5.0.0-master] [git-hash=b33b7fa15b4986db069cfc031bcd7fb827207b0b]
      
@ben1009
Copy link
Contributor

ben1009 commented Jun 23, 2021

fixed by add a validation verifyReplicaConfig when load config

test result
image

config
image

@ben1009 ben1009 closed this as completed Jul 12, 2021
@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. bug-from-internal-test Bugs found by internal testing. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

4 participants