Fix gtest data race detected by tsan check #8565
Conversation
…ring Signed-off-by: yibin <[email protected]>
Signed-off-by: yibin <[email protected]>
Signed-off-by: yibin <[email protected]>
…ort encrypt/decrypt simple data (pingcap#8513) ref pingcap#8351
Signed-off-by: yibin <[email protected]>
Signed-off-by: yibin <[email protected]>
Signed-off-by: yibin <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
/run-all-tests |
ti-chi-bot
bot
added
size/S
|
/run-all-tests |
| @@ -147,11 +147,16 @@ class ComputeServerRunner : public DB::tests::MPPTaskTestUtils | |||
| BlockInputStreamPtr stream; | |||
| try | |||
| { | |||
| auto tasks = prepareMPPTasks( | |||
There was a problem hiding this comment.
how about prepareMPPTasks([&] () { return context.xxx }, properties)?
and then DAGRequestBuilder will under lock
There was a problem hiding this comment.
Maybe MockDAGRequestContext::index should be atomic_size_t?
There was a problem hiding this comment.
Sounds great, I'll change the function signature. Use atomic_size_t can't totally solve the issue here, since builder will reset it to 0 at the end.
There was a problem hiding this comment.
Maybe thread_local size_t index? but seems that mac doesn't support thread_local :(
Signed-off-by: yibin <[email protected]>
|
/run-all-tests |
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/run-integration-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeaRise, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/run-integration-test |
What problem does this PR solve?
Issue Number: ref #8285 #8553
Problem Summary:
In #8553, mutex is added to protect prepareMPPTasks. However, the DAGRequestBuilder parameter is constructed outside the protection, and the context's index will be updated during the construction. This is caused by the two-phase compilation: first for operators without exchange, second for exchange operators. Thus adjust the mutex protection scope in this pr.
Set server's mock storage at beginning to avoid harmless data races.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note