Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support json_contains_path #8502

Merged
merged 17 commits into from
Dec 22, 2023
Merged

Support json_contains_path #8502

merged 17 commits into from
Dec 22, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Dec 12, 2023

What problem does this PR solve?

Issue Number: close #8501

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2023
@SeaRise SeaRise mentioned this pull request Dec 12, 2023
Merged
13 tasks
@SeaRise SeaRise changed the title WIP: Support json_contains_path Support json_contains_path Dec 12, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 12, 2023

/run-all-tests

SeaRise
SeaRise commented Dec 12, 2023
View reviewed changes
tests/_env.sh Outdated Show resolved Hide resolved
tests/_env.sh Outdated Show resolved Hide resolved
@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 12, 2023

/run-all-tests

@SeaRise SeaRise force-pushed the support_json_contains_path branch from 134b8ea to 1ef46e7 Compare December 13, 2023 05:09
SeaRise
SeaRise commented Dec 13, 2023
View reviewed changes
tests/_env.sh Outdated Show resolved Hide resolved
tests/_env.sh Outdated Show resolved Hide resolved
@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 13, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 13, 2023

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 13, 2023

/run-all-tests

@SeaRise SeaRise force-pushed the support_json_contains_path branch from 450e9c7 to 739649a Compare December 13, 2023 10:22
yibin87
yibin87 reviewed Dec 21, 2023
View reviewed changes
dbms/src/Functions/FunctionsJson.h Show resolved Hide resolved
dbms/src/Functions/FunctionsJson.h Outdated Show resolved Hide resolved
@SeaRise SeaRise requested a review from yibin87 December 21, 2023 05:44
yibin87
yibin87 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 21, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 21, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 21, 2023

/run-unit-test

windtalker
windtalker approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 22, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 22, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-21 06:41:29.21476722 +0000 UTC m=+1115980.251994146: ☑️ agreed by yibin87.
  • 2023-12-22 02:29:29.777279936 +0000 UTC m=+1187260.814506864: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit 11c0567 into pingcap:master Dec 22, 2023
6 checks passed
@SeaRise SeaRise deleted the support_json_contains_path branch December 22, 2023 02:45
yibin87 pushed a commit to yibin87/tiflash that referenced this pull request Dec 22, 2023
@SeaRise @yibin87
Support json_contains_path (pingcap#8502)
913482e 
close pingcap#8501
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Dec 27, 2023
@SeaRise @JaySon-Huang
Support json_contains_path (pingcap#8502)
29440bd 
close pingcap#8501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support json_contains_path
3 participants
@SeaRise @windtalker @yibin87