Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: Add json_contains_path push down support for tiflash #49393

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Dec 12, 2023

What problem does this PR solve?

Issue Number: close #49392

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add `json_contains_path` push down support for tiflash

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 12, 2023

/hold
wait for pingcap/tiflash#8502

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2023
Copy link

tiprow bot commented Dec 12, 2023

Hi @SeaRise. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #49393 (8f32a7a) into master (5c279d8) will increase coverage by 0.5033%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49393        +/-   ##
================================================
+ Coverage   70.9855%   71.4888%   +0.5033%     
================================================
  Files          1368       1424        +56     
  Lines        398546     417903     +19357     
================================================
+ Hits         282910     298754     +15844     
- Misses        95871     100276      +4405     
+ Partials      19765      18873       -892     
Flag Coverage Δ
integration 43.9806% <ø> (?)
unit 70.9855% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2654% <ø> (-5.6386%) ⬇️

@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 22, 2023

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Dec 22, 2023

/cc @windtalker @XuHuaiyu

@ti-chi-bot ti-chi-bot bot requested review from windtalker and XuHuaiyu December 22, 2023 02:45
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 22, 2023
Copy link

ti-chi-bot bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 22, 2023
Copy link

ti-chi-bot bot commented Dec 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-22 02:52:17.286231487 +0000 UTC m=+1188628.323458409: ☑️ agreed by windtalker.
  • 2023-12-22 03:06:53.92894 +0000 UTC m=+1189504.966166911: ☑️ agreed by XuHuaiyu.

@ti-chi-bot ti-chi-bot bot merged commit e418f2d into pingcap:master Dec 22, 2023
18 checks passed
@SeaRise SeaRise deleted the tiflash_json_contains_path branch December 22, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support json_contains_path function push down to TiFlash
3 participants