Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: remove raftstore-v2 integration test #8554

Merged
merged 5 commits into from
Dec 21, 2023
Merged

tests: remove raftstore-v2 integration test #8554

merged 5 commits into from
Dec 21, 2023

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Dec 19, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6233

Problem Summary:

What is changed and how it works?

tasks a long time, but has no meaning now, so just remove.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/run-integration-test

1 similar comment
@Lloyd-Pottiger
Copy link
Contributor Author

/run-integration-test

@Lloyd-Pottiger Lloyd-Pottiger deleted the balance-integration-test branch December 19, 2023 12:06
@Lloyd-Pottiger Lloyd-Pottiger restored the balance-integration-test branch December 20, 2023 07:01
@Lloyd-Pottiger
move to fullstack
35a85ab 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger Lloyd-Pottiger changed the title tests: move raftstore-v2 integration test to tests/tidb-ci to balance the execution time tests: move raftstore-v2 integration test to tests/fullstack-test to balance the execution time Dec 20, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/run-integration-test

@Lloyd-Pottiger
just remove
517d20c 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger Lloyd-Pottiger changed the title tests: move raftstore-v2 integration test to tests/fullstack-test to balance the execution time tests: remove raftstore-v2 integration test Dec 20, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 20, 2023
CalvinNeo
CalvinNeo reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also remove tests/docker/cluster-v2.yaml?

@Lloyd-Pottiger
Copy link
Contributor Author

Do we also remove tests/docker/cluster-v2.yaml?

Now we just comment out the test, should we completely remove it?

@Lloyd-Pottiger
remove clear
317d904 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 20, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

Do we also remove tests/docker/cluster-v2.yaml?

removed

CalvinNeo
CalvinNeo approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 21, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-20 08:49:52.729846687 +0000 UTC m=+1037283.767073615: ☑️ agreed by JinheLin.
  • 2023-12-21 02:42:47.615214418 +0000 UTC m=+1101658.652441337: ☑️ agreed by CalvinNeo.

@Lloyd-Pottiger
Copy link
Contributor Author

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

  • Currently the CI jobs are not prow job style, we need it to notify Jenkins server to run them.
  • If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 21, 2023

@Lloyd-Pottiger: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 7449d0e into pingcap:master Dec 21, 2023
6 checks passed
yibin87 pushed a commit to yibin87/tiflash that referenced this pull request Dec 22, 2023
@Lloyd-Pottiger @yibin87
tests: remove raftstore-v2 integration test (pingcap#8554)
751070c 
ref pingcap#6233
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Dec 27, 2023
@Lloyd-Pottiger @JaySon-Huang
tests: remove raftstore-v2 integration test (pingcap#8554)
16abc1c 
ref pingcap#6233
@Lloyd-Pottiger Lloyd-Pottiger deleted the balance-integration-test branch December 29, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinheLin JinheLin JinheLin approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lloyd-Pottiger @CalvinNeo @JinheLin