-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support fetch server info without starting Proxy #7577
Conversation
Signed-off-by: guo-shaoge <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
/run-all-tests |
/run-cherry-picker |
Signed-off-by: guo-shaoge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@guo-shaoge: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: f00bc79
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #7436
Problem Summary:
Before: when tiflash proxy not start, we cannot fetch ServerInfo, so we use a guess value, which is not accurate for some env.
After: Can fetch ServerInfo even when proxy not start(In DisaggMode, TiFlash CN will not start proxy)
What is changed and how it works?
Mainly changes in pingcap/tidb-engine-ext#330 : No need to pass RaftStoreProxyHelper(it need to start proxy to init) to fetch ServerInfo. Only needs EngineStoreServerHelp, which tells rust code how to setup ServerInfo PB msg for tiflash server.
Check List
Tests
Side effects
Documentation
Release note