support fetch server_info without starting Proxy #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
CalvinNeo
reviewed
Jun 1, 2023
| @@ -74,3 +77,29 @@ pub extern "C" fn ffi_server_info( | |||
| engine_store_ffi::ffi::set_server_info_resp(&resp, res); | |||
| 0 | |||
| } | |||
|
|
|||
| #[no_mangle] | |||
| pub extern "C" fn ffi_server_info_noproxy( | |||
There was a problem hiding this comment.
ffi_get_server_info_from_proxy?
Signed-off-by: guo-shaoge <[email protected]>
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
Related TiFlash issue: pingcap/tiflash#7436 (check TiFlash Issue to for Problem Summary)
Related TiFlash PR: pingcap/tiflash#7577
What is changed and how it works?
Add
ffi_server_info_noproxy, which is basically same asffi_server_info.The difference is that:
ffi_server_info_noproxydoesn't need to start proxy, so this function only need pointer of EngineStoreServerHelper, which will setup in TiFlash Server(which contains the real function to setup PB to tiflash server memory). And no need RaftStoreProxyHelper, which needs to start proxy(proxy_server::run_proxy).Check List
Tests
Side effects
Documentation
Release note