Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of physical core detected by tiflash compute node(Disagg Mode) is not accurate #7436

Closed
guo-shaoge opened this issue May 8, 2023 · 2 comments · Fixed by #7577
Closed
Assignees
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@guo-shaoge
Copy link
Contributor

guo-shaoge commented May 8, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

Actual cpu info: 8 cores

Architecture:                    aarch64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
CPU(s):                          8
On-line CPU(s) list:             0-7
Thread(s) per core:              1
Core(s) per socket:              8
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       ARM
Model:                           1
Model name:                      Neoverse-N1
Stepping:                        r3p1
BogoMIPS:                        243.75
L1d cache:                       512 KiB
L1i cache:                       512 KiB
L2 cache:                        8 MiB
L3 cache:                        32 MiB
NUMA node0 CPU(s):               0-7
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Mmio stale data:   Not affected
Vulnerability Retbleed:          Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:        Mitigation; __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; CSV2, BHB
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected
Flags:                           fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm lrcpc dcpop asimddp ssbs

3. What did you see instead (Required)

TiFlash Compute Node (in Disagg Mode)only see 4 cores

tiflash.log:[2023/05/08 06:59:49.483 +00:00] [INFO] [getNumberOfCPUCores.cpp:72] ["logical cpu cores: 8, hardware logical cpu cores: 8, hardware physical cpu cores: 4, physical cpu cores: 4, number_of_physical_cpu_cores: 4"] [thread_id=1]
tiflash.log:[2023/05/08 06:59:49.591 +00:00] [INFO] [Server.cpp:1564] ["Available RAM = 66606178304; physical cores = 4; logical cores = 8."] [thread_id=1]

4. What is your TiFlash version? (Required)

master

@guo-shaoge guo-shaoge added the type/bug The issue is confirmed as a bug. label May 8, 2023
@guo-shaoge
Copy link
Contributor Author

@guo-shaoge
Copy link
Contributor Author

guo-shaoge commented May 8, 2023

Use this command: tiup playground --without-monitor --tiflash 1 on the same machine, and check the log of tiflash:

[2023/05/08 08:16:59.748 +00:00] [INFO] [getNumberOfCPUCores.cpp:72] ["logical cpu cores: 8, hardware logical cpu cores: 8, hardware physical cpu cores: 8, physical cpu cores: 8, number_of_physical_cpu_cores: 8"] [thread_id=1]
[2023/05/08 08:16:59.748 +00:00] [INFO] [Server.cpp:1064] ["ServerInfo: CPU: \n     logical cores: 8\n     physical cores: 8\n     frequency: 0MHz\n     l1 cache size: 65536\n     l1 cache line size: 64\n     l2 cache size: 1048576\n     l2 cache line size: 64\n     l3 cache size: 33554432\n     l3 cache line size: 64\n     arch: arm64\nDisk: \n     name: /dev/nvme1n1p1\n     type: SSD\n     total space: 21113950208\n     free space: 11979235328\n     mount point: /tiflash/log\n     fstype: ext4\nDisk: \n     name: /dev/nvme1n1p1\n     type: SSD\n     total space: 21113950208\n     free space: 11979235328\n     mount point: /etc/hosts\n     fstype: ext4\nDisk: \n     name: /dev/nvme1n1p1\n     type: SSD\n     total space: 21113950208\n     free space: 11979235328\n     mount point: /dev/termination-log\n     fstype: ext4\nDisk: \n     name: /dev/nvme1n1p1\n     type: SSD\n     total space: 21113950208\n     free space: 11979235328\n     mount point: /etc/hostname\n     fstype: ext4\nDisk: \n     name: /dev/nvme1n1p1\n     type: SSD\n     total space: 21113950208\n     free space: 11979235328\n     mount point: /etc/resolv.conf\n     fstype: ext4\nDisk: \n     name: /dev/nvme3n1\n     type: SSD\n     total space: 116060844032\n     free space: 111166472192\n     mount point: /data\n     fstype: ext4\nDisk: \n     name: overlay\n     type: UNKNOWN\n     total space: 21113950208\n     free space: 11979235328\n     mount point: /\n     fstype: overlay\nMemory: \n     capacity: 66606178304\n"] [thread_id=1]

So the number of physical cores collected by proxy is correct. So we need to copy proxy code for CN.( Because CN doesn't start proxy).

@guo-shaoge guo-shaoge changed the title Number of physical core in tiflash compute node is wrong Number of physical core detected by tiflash compute node is not accurate May 8, 2023
@guo-shaoge guo-shaoge self-assigned this May 31, 2023
@guo-shaoge guo-shaoge changed the title Number of physical core detected by tiflash compute node is not accurate Number of physical core detected by tiflash compute node(Disagg Mode) is not accurate May 31, 2023
@ti-chi-bot ti-chi-bot bot closed this as completed in #7577 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant