Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Fix RegionBlockReaderTest helper functions (#5899) #5924

Merged
merged 3 commits into from
Sep 26, 2022
Merged

tests: Fix RegionBlockReaderTest helper functions (#5899) #5924

merged 3 commits into from
Sep 26, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5899

Signed-off-by: JaySon-Huang [email protected]

What problem does this PR solve?

Issue Number: ref #5859

Problem Summary:
The helper functions in RegionBlockReaderTestFixture is buggy when testing with primary key columns.

What is changed and how it works?

Fix the testing helper functions.
A pre-split PR for #5879

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 16, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 16, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Sep 16, 2022
@JaySon-Huang
Resolve conflicts
063e7f4 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang JaySon-Huang force-pushed the cherry-pick-5899-to-release-5.4 branch from 88e58fa to 063e7f4 Compare September 19, 2022 11:50
@JaySon-Huang
Copy link
Contributor

/run-unit-test

@JaySon-Huang JaySon-Huang mentioned this pull request Sep 20, 2022
Merged
@JaySon-Huang
Copy link
Contributor

/rebuild

1 similar comment
@JaySon-Huang
Copy link
Contributor

/rebuild

@JaySon-Huang
backport getColumnsContent
e337612 
Signed-off-by: JaySon-Huang <[email protected]>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 23, 2022
@JaySon-Huang JaySon-Huang mentioned this pull request Sep 23, 2022
Merged
@JaySon-Huang
Copy link
Contributor

/rebuild

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 23, 2022

lines: 30.2% (3259 out of 10801)
branches: 13.6% (2333 out of 17143)

JaySon-Huang added a commit to ti-chi-bot/tiflash that referenced this pull request Sep 26, 2022
@JaySon-Huang
This is a suqashed commit from pingcap#5924
b39d2a5 
Signed-off-by: ti-chi-bot <[email protected]>
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 26, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

@JaySon-Huang: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 26, 2022

lines: 30.2% (3259 out of 10801)
branches: 13.6% (2333 out of 17143)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 26, 2022
@JaySon-Huang JaySon-Huang added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: e337612

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 26, 2022

lines: 30.2% (3259 out of 10801)
branches: 13.6% (2333 out of 17143)

@ti-chi-bot ti-chi-bot merged commit 8fc3b1c into pingcap:release-5.4 Sep 26, 2022
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Sep 27, 2022
@ti-chi-bot @JaySon-Huang
tests: Fix RegionBlockReaderTest helper functions (pingcap#5899) (pin…
04c303a 
…gcap#5924)

ref pingcap#5859
@JaySon-Huang JaySon-Huang mentioned this pull request Sep 27, 2022
Merged
12 tasks
JaySon-Huang added a commit that referenced this pull request Oct 31, 2022
@JaySon-Huang @ti-chi-bot
Fix two DDL bugs on hotfix branch (#6042)
f0d54d6 
* DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166) (#5191)

close #5154

* tests: Fix RegionBlockReaderTest helper functions (#5899) (#5924)

ref #5859

* Fix decode error when "NULL" value in the column with "primary key" flag (#5879) (#5932)

close #5859

Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@JaySon-Huang JaySon-Huang

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @JaySon-Huang @sre-bot @lidezhu @VelocityLight