-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decode error when "NULL" value in the column with "primary key" flag #5879
Fix decode error when "NULL" value in the column with "primary key" flag #5879
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
e46aa67
to
19d4dc1
Compare
/run-all-tests |
/cc @lidezhu @hongyunyan |
/run-all-tests |
The helper functions in |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
In response to a cherrypick label: new pull request created: #5934. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5935. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5936. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5937. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5938. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5939. |
In response to a cherrypick label: new pull request created: #5940. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
* DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166) (#5191) close #5154 * tests: Fix RegionBlockReaderTest helper functions (#5899) (#5924) ref #5859 * Fix decode error when "NULL" value in the column with "primary key" flag (#5879) (#5932) close #5859 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #5859
Problem Summary:
TiFlash assumes all values in the column with "primary key" flag are non-null value.
However, users could create such "NULL" value in the "primary key" column by following steps
What is changed and how it works?
addDefaultValueToColumnIfPossible
insertRangeFrom
preHandleSnapshot
/ingestSST
Check List
Tests
Side effects
Documentation
Release note