-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166) #5191
DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166) #5191
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
fix merge master error
fix merge error
fix format error
fix clang tidy
fix clang tidy
/run-all-tests |
/run-all-tests |
lines: 43.5% (50299 out of 115501) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: c3d4fe9
|
lines: 43.5% (50300 out of 115501) |
* DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166) (#5191) close #5154 * tests: Fix RegionBlockReaderTest helper functions (#5899) (#5924) ref #5859 * Fix decode error when "NULL" value in the column with "primary key" flag (#5879) (#5932) close #5859 Co-authored-by: Ti Chi Robot <[email protected]>
This is an automated cherry-pick of #5166
What problem does this PR solve?
Issue Number: close #5154
Problem Summary:
What is changed and how it works?
in decodingSchemaSnapshot, we use column name instead of offset to find cluster index id of the common handle. Because in tiflash, we don't update the indexinfo of table_info except rename ddl action. Thus, the offset of tidb_table_info is not correctly in sometimes.
Besides, I add two DDL tests based on issue #5154, concerning about clustered index.
Check List
Tests
Side effects
Documentation
Release note