fix: elim sign comparison in basedaemon

[SchrodingerZhu]

Signed-off-by: SchrodingerZhu [email protected]

What problem does this PR solve?

Issue Number: close #4372

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang
• fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[SchrodingerZhu]

/run-all-tests

[SchrodingerZhu]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
dbms/src/Common/tests/gtest_stacktrace.cpp          68                 2    97.06%           6                 0   100.00%          54                 0   100.00%          28                 6    78.57%
libs/libdaemon/src/BaseDaemon.cpp                  564               379    32.80%          40                20    50.00%         853               434    49.12%         368               267    27.45%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              632               381    39.72%          46                20    56.52%         907               434    52.15%         396               273    31.06%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17040      9576             43.80%    191885  97032        49.43%

full coverage report (for internal network access only)

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 64c0f5b

[sre-bot]

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
dbms/src/Common/tests/gtest_stacktrace.cpp          68                 2    97.06%           6                 0   100.00%          54                 0   100.00%          28                 5    82.14%
libs/libdaemon/src/BaseDaemon.cpp                  564               379    32.80%          40                20    50.00%         853               434    49.12%         368               267    27.45%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              632               381    39.72%          46                20    56.52%         907               434    52.15%         396               272    31.31%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17040      9576             43.80%    191885  97049        49.42%

full coverage report (for internal network access only)