fix: elim sign comparison in basedaemon (#4368)

close #4372
pingcap · Mar 22, 2022 · e919a61 · e919a61
1 parent 5c21a37
commit e919a61
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/dbms/src/Common/tests/gtest_stacktrace.cpp b/dbms/src/Common/tests/gtest_stacktrace.cpp
@@ -51,12 +51,12 @@ GTEST_NO_INLINE_ void function_2(bool output = false, size_t level = 0)
 {
     function_1(output, level);
 }
-TEST(StacTrace, SingleThread)
+TEST(StackTrace, SingleThread)
 {
     function_2(true);
     function_2(true, 16);
 }
-TEST(StacTrace, MultiThreads)
+TEST(StackTrace, MultiThreads)
 {
     size_t num = std::thread::hardware_concurrency();
     std::vector<std::thread> threads{};

diff --git a/libs/libdaemon/src/BaseDaemon.cpp b/libs/libdaemon/src/BaseDaemon.cpp
@@ -538,8 +538,8 @@ class SignalListener : public Poco::Runnable
         if (already_printed_stack_trace)
             return;
 
-        static constexpr int max_frames = 50;
-        int frames_size = 0;
+        static constexpr size_t max_frames = 50;
+        size_t frames_size = 0;
         void * frames[max_frames];
 
 #if USE_UNWIND